Chromium Code Reviews

Unified Diff: test/mjsunit/es6/generators-objects.js

Issue 1530213002: Make generators non-constructable (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Remove broken tests Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Index: test/mjsunit/es6/generators-objects.js
diff --git a/test/mjsunit/es6/generators-objects.js b/test/mjsunit/es6/generators-objects.js
index 9390776761607df9c963479e1c601e61c331fff9..2833dd8994550fb92f6fd8482247ebe99b68a930 100644
--- a/test/mjsunit/es6/generators-objects.js
+++ b/test/mjsunit/es6/generators-objects.js
@@ -60,9 +60,6 @@ function TestGeneratorObject() {
assertEquals([], Object.getOwnPropertyNames(iter));
assertTrue(iter !== g());
- // g() is the same as new g().
- iter = new g();
- assertSame(g.prototype, Object.getPrototypeOf(iter));
assertTrue(iter instanceof g);
assertEquals("Generator", %_ClassOf(iter));
assertEquals("[object Generator]", String(iter));
neis 2016/01/14 10:55:23 These three are duplicates now.
@@ -70,7 +67,10 @@ function TestGeneratorObject() {
var gf = iter.__proto__.constructor;
assertEquals("[object GeneratorFunction]", Object.prototype.toString.call(gf));
assertEquals([], Object.getOwnPropertyNames(iter));
- assertTrue(iter !== new g());
+ assertTrue(iter !== g());
+
+ // generators are not constructable.
+ assertThrows(()=>new g());
}
TestGeneratorObject();

Powered by Google App Engine