Add |git cl description| to allow you to change the description in your favorite $EDITOR.

Add |git cl description| to allow you to change the description in your favorite $EDITOR.

R=maruel@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201094

[M-A Ruel, 2013-05-17 18:46:00]

FTR, since you didn't add any unit test, you'll be forever on the hook if any
breakage ever happens. It's a trade off, I don't consider these utility|optional
commands to necessarily require a unit test.

I like this command, thanks for adding it. Next would be reviewers/cc. :)

lgtm

https://codereview.chromium.org/15302014/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/15302014/diff/1/git_cl.py#newcode1124
git_cl.py:1124: """Brings up the editor for the current CL's description."""
The docstrings for commands start with a lower case because they are printed
as-is. I see issue and try do not follow the rest, oops.

https://codereview.chromium.org/15302014/diff/1/git_cl.py#newcode1130
git_cl.py:1130: cl.UpdateDescription(description.description)
return 0

[Robert Sesek, 2013-05-17 19:02:13]

On 2013/05/17 18:46:00, Marc-Antoine Ruel wrote:
> FTR, since you didn't add any unit test, you'll be forever on the hook if any
> breakage ever happens. It's a trade off, I don't consider these
utility|optional
> commands to necessarily require a unit test.
> 
> I like this command, thanks for adding it. Next would be reviewers/cc. :)
> 
> lgtm

I couldn't find an easy way to write a meaningful test :/

[Robert Sesek, 2013-05-17 19:02:17]

https://codereview.chromium.org/15302014/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/15302014/diff/1/git_cl.py#newcode1124
git_cl.py:1124: """Brings up the editor for the current CL's description."""
On 2013/05/17 18:46:00, Marc-Antoine Ruel wrote:
> The docstrings for commands start with a lower case because they are printed
> as-is. I see issue and try do not follow the rest, oops.

Done.

https://codereview.chromium.org/15302014/diff/1/git_cl.py#newcode1130
git_cl.py:1130: cl.UpdateDescription(description.description)
On 2013/05/17 18:46:00, Marc-Antoine Ruel wrote:
> return 0

Done.

[Robert Sesek, 2013-05-20 16:28:01]

Committed patchset #2 manually as r201094.