Convert ToBooleanStub to a HydrogenStub. Currently just using HBranch, which is still fully impleme…

src/checks.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 247 matching lines @@
 // generates code in debug builds.
 #ifdef DEBUG
 #define ASSERT_RESULT(expr)    CHECK(expr)
 #define ASSERT(condition)      CHECK(condition)
 #define ASSERT_EQ(v1, v2)      CHECK_EQ(v1, v2)
 #define ASSERT_NE(v1, v2)      CHECK_NE(v1, v2)
 #define ASSERT_GE(v1, v2)      CHECK_GE(v1, v2)
 #define ASSERT_LT(v1, v2)      CHECK_LT(v1, v2)
 #define ASSERT_LE(v1, v2)      CHECK_LE(v1, v2)
 #define SLOW_ASSERT(condition) CHECK(!FLAG_enable_slow_asserts || (condition))
+#define FOR_ASSERT(statement)  statement
 #else
 #define ASSERT_RESULT(expr)    (expr)
 #define ASSERT(condition)      ((void) 0)
 #define ASSERT_EQ(v1, v2)      ((void) 0)
 #define ASSERT_NE(v1, v2)      ((void) 0)
 #define ASSERT_GE(v1, v2)      ((void) 0)
 #define ASSERT_LT(v1, v2)      ((void) 0)
 #define ASSERT_LE(v1, v2)      ((void) 0)
 #define SLOW_ASSERT(condition) ((void) 0)
+#define FOR_ASSERT(statement)  ((void) 0)

[Toon Verwaest, 2013/05/28 09:33:32]

What about just putting the statement in #ifdef DEBUG?

 #endif
 // Static asserts has no impact on runtime performance, so they can be
 // safely enabled in release mode. Moreover, the ((void) 0) expression
 // obeys different syntax rules than typedef's, e.g. it can't appear
 // inside class declaration, this leads to inconsistency between debug
 // and release compilation modes behavior.
 #define STATIC_ASSERT(test)  STATIC_CHECK(test)
 
 #define ASSERT_NOT_NULL(p)  ASSERT_NE(NULL, p)
 
 // "Extra checks" are lightweight checks that are enabled in some release
 // builds.
 #ifdef ENABLE_EXTRA_CHECKS
 #define EXTRA_CHECK(condition) CHECK(condition)
 #else
 #define EXTRA_CHECK(condition) ((void) 0)
 #endif
 
 #endif  // V8_CHECKS_H_