Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: tools/gn/target_unittest.cc

Issue 1530183005: Special-case paths that appear in libs by not prefixing them with -l. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: treat source_file libs as inputs Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/gn/target_unittest.cc
diff --git a/tools/gn/target_unittest.cc b/tools/gn/target_unittest.cc
index e7c4c31bd820abec72376840827b21241f5387ca..986fa658e106d1e8a28cad4db37b02911940e0e3 100644
--- a/tools/gn/target_unittest.cc
+++ b/tools/gn/target_unittest.cc
@@ -35,7 +35,7 @@ TEST(Target, LibInheritance) {
TestWithScope setup;
Err err;
- const std::string lib("foo");
+ const LibFile lib("foo");
const SourceDir libdir("/foo_dir/");
// Leaf target with ldflags set.
@@ -52,7 +52,7 @@ TEST(Target, LibInheritance) {
// Shared library target should inherit the libs from the static library
// and its own. Its own flag should be before the inherited one.
- const std::string second_lib("bar");
+ const LibFile second_lib("bar");
const SourceDir second_libdir("/bar_dir/");
TestTarget shared(setup, "//foo:shared", Target::SHARED_LIBRARY);
shared.config_values().libs().push_back(second_lib);
@@ -386,7 +386,7 @@ TEST(Target, PublicConfigs) {
Label pub_config_label(SourceDir("//a/"), "pubconfig");
Config pub_config(setup.settings(), pub_config_label);
- std::string lib_name("testlib");
+ LibFile lib_name("testlib");
pub_config.own_values().libs().push_back(lib_name);
ASSERT_TRUE(pub_config.OnResolved(&err));

Powered by Google App Engine
This is Rietveld 408576698