Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(698)

Unified Diff: tools/gn/target.cc

Issue 1530183005: Special-case paths that appear in libs by not prefixing them with -l. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: treat source_file libs as inputs Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/gn/target.cc
diff --git a/tools/gn/target.cc b/tools/gn/target.cc
index 16a0ba4eb8ff65ba6fa328b9df61a22546a74321..6fa9c666acae2a87a0da21a9a16f5820e175ec23 100644
--- a/tools/gn/target.cc
+++ b/tools/gn/target.cc
@@ -552,6 +552,11 @@ void Target::CheckSourcesGenerated() const {
CheckSourceGenerated(file);
for (const SourceFile& file : inputs_)
CheckSourceGenerated(file);
+ for (size_t i = 0; i < all_libs_.size(); i++) {
+ if (all_libs_[i].is_source_file()) {
brettw 2015/12/18 00:04:55 No {}
agrieve 2015/12/18 15:39:08 Done.
+ CheckSourceGenerated(all_libs_[i].source_file());
+ }
+ }
}
void Target::CheckSourceGenerated(const SourceFile& source) const {

Powered by Google App Engine
This is Rietveld 408576698