Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Unified Diff: tools/gn/command_desc.cc

Issue 1530183005: Special-case paths that appear in libs by not prefixing them with -l. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: treat source_file libs as inputs Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/gn/command_desc.cc
diff --git a/tools/gn/command_desc.cc b/tools/gn/command_desc.cc
index 3f2bbaf51fb15b23ad9d3545eb46d1a4164de7ee..88d295aebc8c2c19edf514a4c0afa4e2fe048c5f 100644
--- a/tools/gn/command_desc.cc
+++ b/tools/gn/command_desc.cc
@@ -169,15 +169,16 @@ void PrintLibDirs(const Target* target, bool display_header) {
}
void PrintLibs(const Target* target, bool display_header) {
- const OrderedSet<std::string>& libs = target->all_libs();
+ const OrderedSet<LibFile>& libs = target->all_libs();
if (libs.empty())
return;
if (display_header)
OutputString("\nlibs\n");
- for (size_t i = 0; i < libs.size(); i++)
- OutputString(" " + libs[i] + "\n");
+ for (size_t i = 0; i < libs.size(); i++) {
brettw 2015/12/18 00:04:55 No {} for single-line conditionals.
agrieve 2015/12/18 15:39:07 Done.
+ OutputString(" " + libs[i].value() + "\n");
+ }
}
void PrintPublic(const Target* target, bool display_header) {
« no previous file with comments | « tools/gn/BUILD.gn ('k') | tools/gn/config_values.h » ('j') | tools/gn/config_values_generator.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698