Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: tools/gn/variables.cc

Issue 1530183005: Special-case paths that appear in libs by not prefixing them with -l. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix typo in previous patch Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/value_extractors.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/variables.cc
diff --git a/tools/gn/variables.cc b/tools/gn/variables.cc
index d79c3aa887defcdf0101ab393ca6099bd7c71b3b..a835b22d6b2c6fa5db7dd999dd9a3730e4070550 100644
--- a/tools/gn/variables.cc
+++ b/tools/gn/variables.cc
@@ -892,20 +892,20 @@ const char kLibs_HelpShort[] =
const char kLibs_Help[] =
"libs: Additional libraries to link.\n"
"\n"
- " A list of strings.\n"
- "\n"
- " These files will be passed to the linker, which will generally search\n"
- " the library include path. Unlike a normal list of files, they will be\n"
- " passed to the linker unmodified rather than being treated as file\n"
- " names relative to the current build file. Generally you would set\n"
- " the \"lib_dirs\" so your library is found. If you need to specify\n"
- " a path, you can use \"rebase_path\" to convert a path to be relative\n"
- " to the build directory.\n"
- "\n"
- " When constructing the linker command, the \"lib_prefix\" attribute of\n"
- " the linker tool in the current toolchain will be prepended to each\n"
- " library. So your BUILD file should not specify the switch prefix\n"
- " (like \"-l\").\n"
+ " A list of library names or library paths.\n"
+ "\n"
+ "Values containing '/' will be treated as references to files in the\n"
+ "build. They will be rebased to be relative to the build directory and\n"
+ "specified in the \"libs\" for linker tools. This facility should be used\n"
+ "for libraries that are checked in to the build. For libraries that are\n"
+ "generated by the build, use normal GN deps to link them.\n"
+ "\n"
+ "Values not containing '/' will be treated as system library names. These\n"
+ "will be passed unmodified to the linker and prefixed with the\n"
+ "\"lib_prefix\" attribute of the linker tool. Generally you would set the\n"
+ "\"lib_dirs\" so the given library is found. Your BUILD.gn file should\n"
+ "not specify the switch prefix (like \"-l\"): this will be encoded in\n"
+ "the \"lib_prefix\" of the tool.\n"
"\n"
" Libraries ending in \".framework\" will be special-cased: the switch\n"
" \"-framework\" will be prepended instead of the lib_prefix, and the\n"
« no previous file with comments | « tools/gn/value_extractors.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698