Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1168)

Unified Diff: tools/gn/value_extractors.h

Issue 1530183005: Special-case paths that appear in libs by not prefixing them with -l. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix typo in previous patch Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/test_with_scope.cc ('k') | tools/gn/value_extractors.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/value_extractors.h
diff --git a/tools/gn/value_extractors.h b/tools/gn/value_extractors.h
index 2482ba25bf2b3a82e19d6adc29585eb5fe6f67ed..06d64cef676e78d62fdc0c9c1dfa19f963567739 100644
--- a/tools/gn/value_extractors.h
+++ b/tools/gn/value_extractors.h
@@ -9,6 +9,7 @@
#include <vector>
#include "tools/gn/label_ptr.h"
+#include "tools/gn/lib_file.h"
#include "tools/gn/unique_vector.h"
class BuildSettings;
@@ -30,6 +31,14 @@ bool ExtractListOfRelativeFiles(const BuildSettings* build_settings,
std::vector<SourceFile>* files,
Err* err);
+// Extracts a list of libraries. When they contain a "/" they are treated as
+// source paths and are otherwise treated as plain strings.
+bool ExtractListOfLibs(const BuildSettings* build_settings,
+ const Value& value,
+ const SourceDir& current_dir,
+ std::vector<LibFile>* libs,
+ Err* err);
+
// Looks for a list of source directories relative to a given current dir.
bool ExtractListOfRelativeDirs(const BuildSettings* build_settings,
const Value& value,
« no previous file with comments | « tools/gn/test_with_scope.cc ('k') | tools/gn/value_extractors.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698