tools/gn/target.cc - Issue 1530183005: Special-case paths that appear in libs by not prefixing them with -l.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/target.cc

Issue 1530183005: Special-case paths that appear in libs by not prefixing them with -l. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix typo in previous patch Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gn/target.cc

diff --git a/tools/gn/target.cc b/tools/gn/target.cc

index 16a0ba4eb8ff65ba6fa328b9df61a22546a74321..0d275ac93584e1a77c58c2ae00099ee75b5f865b 100644

--- a/tools/gn/target.cc

+++ b/tools/gn/target.cc

@@ -552,6 +552,10 @@ void Target::CheckSourcesGenerated() const {

CheckSourceGenerated(file);

for (const SourceFile& file : inputs_)

CheckSourceGenerated(file);

+ for (size_t i = 0; i < all_libs_.size(); i++) {

+ if (all_libs_[i].is_source_file())

+ CheckSourceGenerated(all_libs_[i].source_file());

+ }

}

void Target::CheckSourceGenerated(const SourceFile& source) const {

« no previous file with comments | « tools/gn/target.h ('k') | tools/gn/target_unittest.cc » ('j') | no next file with comments »