Special-case paths that appear in libs by not prefixing them with -l.

tools/gn/lib_file.h

+// Copyright (c) 2015 The Chromium Authors. All rights reserved.

[tfarina, 2015/12/17 18:52:44]

no (c)

[agrieve, 2015/12/17 19:33:34]

Done.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef TOOLS_GN_LIB_FILE_H_
+#define TOOLS_GN_LIB_FILE_H_
+
+#include <algorithm>
+#include <string>
+
+#include "base/strings/string_piece.h"
+#include "tools/gn/source_file.h"
+
+// Represents a file within the source tree. Always begins in a slash, never

[tfarina, 2015/12/17 18:52:44]

This is too vague. A file could be anything. But the class is named Lib. Which
lib file is that? I think you are referring to libfoo.a? Does it also represent
libfoo.so?

[agrieve, 2015/12/17 19:33:34]

Done.

+// ends in one.
+class LibFile {
+ public:
+  LibFile();
+  explicit LibFile(const base::StringPiece& lib_name);
+  explicit LibFile(const SourceFile& source_file);
+
+  void swap(LibFile& other);

[tfarina, 2015/12/17 18:52:44]

no non-const references.

[agrieve, 2015/12/17 19:33:34]

Done.

+  bool is_source_file() const { return name_.empty(); }

[tfarina, 2015/12/17 18:52:44]

I would add a blank line after this.

[agrieve, 2015/12/17 19:33:34]

Done.

+  // Returns name, or source_file().value() (whichever is set).
+  const std::string& value() const;
+  const SourceFile& source_file() const;
+
+  bool operator==(const LibFile& other) const {
+    return value() == other.value();
+  }
+  bool operator!=(const LibFile& other) const {
+    return !operator==(other);
+  }
+  bool operator<(const LibFile& other) const {
+    return value() < other.value();
+  }

[tfarina, 2015/12/17 18:52:44]

blank line

[agrieve, 2015/12/17 19:33:34]

Done.

+ private:
+  std::string name_;
+  SourceFile source_file_;
+};
+
+namespace BASE_HASH_NAMESPACE {
+
+template<> struct hash<LibFile> {
+  std::size_t operator()(const LibFile& v) const {
+    hash<std::string> h;
+    return h(v.value());
+  }
+};
+
+}  // namespace BASE_HASH_NAMESPACE
+
+inline void swap(LibFile& lhs, LibFile& rhs) {
+  lhs.swap(rhs);
+}
+
+#endif  // TOOLS_GN_LIB_FILE_H_