Revert 3 CLs for shouldOverrideUrlLoading implementation.

Revert 3 CLs for shouldOverrideUrlLoading implementation.

Since https://codereview.chromium.org/1424263003 does not handle
overriding about:blank loads (or rather, about:blank loads are
handled synchronously and can thus be finished before we have a chance
to override them) we cannot land that patch without potentially breaking
lots of apps using WebView.

The second CL being reverted is a fix for the first one to post
didStopLoad and didFailLoad in the correct order.

The third CL being reverted here is a small change removing code that
is not used by https://codereview.chromium.org/1424263003 but is used
now that we revert that CL.

This reverts commit bae3ff13e6959b713b872df3c4a734d6a1ea01ad.
This reverts commit e1da704f67f34022b7aaf3afe277c86217844114.
This reverts commit c002c7ea9c5a3dbeb665e4070d852e6724d1ff86.

TBR=palmer@chromium.org,jam@chromium.org
BUG=325351, 462306
Committed: https://crrev.com/68afca713e53e857cbc6c2d25aeb0bb1d76cd4ac
Cr-Commit-Position: refs/heads/master@{#368849}

[gsennton, 2016-01-05 20:19:06]

gsennton@chromium.org changed reviewers:
+ japhet@chromium.org, mnaganov@chromium.org, sgurun@chromium.org

[gsennton, 2016-01-05 20:19:06]

Heyo, since https://codereview.chromium.org/1424263003 will have to be postponed
a bit I think it would be good to get this reverted before 49 branches.

https://codereview.chromium.org/1440933004/ is reverted because the WebView
instrumentation test added there seems to be failing without
https://codereview.chromium.org/1424263003 (and 
https://codereview.chromium.org/1440933004/ also amplifies crbug.com/567044).

Will TBR the rest of the owners from the original CLs.

[mnaganov (inactive), 2016-01-05 20:26:44]

lgtm

[sgurun-gerrit only, 2016-01-05 20:38:38]

On 2016/01/05 20:26:44, mnaganov wrote:
> lgtm

lgtm from me too

[gsennton, 2016-01-06 12:36:38]

Description was changed from

==========
Revert 3 CLs for shouldOverrideUrlLoading implementation.

Since https://codereview.chromium.org/1424263003 does not handle
overriding about:blank loads (or rather, about:blank loads are
handled synchronously and can thus be finished before we have a chance
to override them) we cannot land that patch without potentially breaking
lots of apps using WebView.

The second CL being reverted is a fix for the first one to post
didStopLoad and didFailLoad in the correct order.

The third CL being reverted here is a small change removing code that
is not used by https://codereview.chromium.org/1424263003 but is used
now that we revert that CL.

This reverts commit bae3ff13e6959b713b872df3c4a734d6a1ea01ad.
This reverts commit e1da704f67f34022b7aaf3afe277c86217844114.
This reverts commit c002c7ea9c5a3dbeb665e4070d852e6724d1ff86.

BUG=325351,462306
==========

to

==========
Revert 3 CLs for shouldOverrideUrlLoading implementation.

Since https://codereview.chromium.org/1424263003 does not handle
overriding about:blank loads (or rather, about:blank loads are
handled synchronously and can thus be finished before we have a chance
to override them) we cannot land that patch without potentially breaking
lots of apps using WebView.

The second CL being reverted is a fix for the first one to post
didStopLoad and didFailLoad in the correct order.

The third CL being reverted here is a small change removing code that
is not used by https://codereview.chromium.org/1424263003 but is used
now that we revert that CL.

This reverts commit bae3ff13e6959b713b872df3c4a734d6a1ea01ad.
This reverts commit e1da704f67f34022b7aaf3afe277c86217844114.
This reverts commit c002c7ea9c5a3dbeb665e4070d852e6724d1ff86.

TBR=palmer@chromium.org,jam@chromium.org
BUG=325351,462306
==========

[gsennton, 2016-01-06 12:36:38]

gsennton@chromium.org changed reviewers:
+ creis@chromium.org, jam@chromium.org, palmer@chromium.org

[gsennton, 2016-01-06 12:38:52]

Updated TBRs and reviewers.

creis@, sadly I'm re-enabling the DidStopLoadingDetails tests again since
https://codereview.chromium.org/1440933004/ is being reverted :(

[Charlie Reis, 2016-01-06 16:12:45]

On 2016/01/06 12:38:52, gsennton wrote:
> Updated TBRs and reviewers.
> 
> creis@, sadly I'm re-enabling the DidStopLoadingDetails tests again since
> https://codereview.chromium.org/1440933004/ is being reverted :(

That's too bad.  The revert of https://codereview.chromium.org/1440933004/ LGTM
as part of that.  Are you planning to try again a different way?

[gsennton, 2016-01-06 17:39:40]

On 2016/01/06 16:12:45, Charlie Reis wrote:
> On 2016/01/06 12:38:52, gsennton wrote:
> > Updated TBRs and reviewers.
> > 
> > creis@, sadly I'm re-enabling the DidStopLoadingDetails tests again since
> > https://codereview.chromium.org/1440933004/ is being reverted :(
> 
> That's too bad.  The revert of https://codereview.chromium.org/1440933004/
LGTM
> as part of that.  Are you planning to try again a different way?

Yup, the major issue right now is that we cannot support calling
shouldOverrideUrlLoading for about:blank with the current solution (see
crbug.com/462306) we will probably end up not supporting calling
shouldOverrideUrlLoading for about:blank in the future (since the alternative
would be to make about:blank loads asynchronous which would be a major change
for Blink).

Since the code in https://codereview.chromium.org/1440933004/ fixes a bug with
how Blink works now (even though it seems only WebView is affected by this bug)
we should probably try to land that before the whole about:blank issue is solved
- the problem with that CL is that the instrumentation test I added there fails
when we revert https://codereview.chromium.org/1424263003 and that the CL
amplifies crbug.com/567044 (and I have not had time to look into these issues).

[gsennton, 2016-01-09 15:33:31]

japhet@, I just wanted to make sure that you see this revert as well.

[Nate Chapin, 2016-01-12 00:22:11]

On 2016/01/09 15:33:31, gsennton wrote:
> japhet@, I just wanted to make sure that you see this revert as well.

LGTM :(

[gsennton, 2016-01-12 09:35:44]

The CQ bit was checked by gsennton@chromium.org

[gsennton, 2016-01-12 09:35:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
mnaganov@chromium.org
Link to the patchset: https://codereview.chromium.org/1530183004/#ps20001
(title: "Rebase.")

[commit-bot: I haz the power, 2016-01-12 09:35:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1530183004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1530183004/20001

[commit-bot: I haz the power, 2016-01-12 09:38:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-12 09:38:06]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[gsennton, 2016-01-12 09:49:00]

The CQ bit was checked by gsennton@chromium.org

[gsennton, 2016-01-12 09:49:00]

The patchset sent to the CQ was uploaded after l-g-t-m from sgurun@chromium.org,
mnaganov@chromium.org, creis@chromium.org, japhet@chromium.org
Link to the patchset: https://codereview.chromium.org/1530183004/#ps40001
(title: "Rebase (simple conflict in
AwContentsClientShouldOverrideUrlLoadingTest).")

[commit-bot: I haz the power, 2016-01-12 09:49:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1530183004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1530183004/40001

[commit-bot: I haz the power, 2016-01-12 11:07:40]

Description was changed from

==========
Revert 3 CLs for shouldOverrideUrlLoading implementation.

Since https://codereview.chromium.org/1424263003 does not handle
overriding about:blank loads (or rather, about:blank loads are
handled synchronously and can thus be finished before we have a chance
to override them) we cannot land that patch without potentially breaking
lots of apps using WebView.

The second CL being reverted is a fix for the first one to post
didStopLoad and didFailLoad in the correct order.

The third CL being reverted here is a small change removing code that
is not used by https://codereview.chromium.org/1424263003 but is used
now that we revert that CL.

This reverts commit bae3ff13e6959b713b872df3c4a734d6a1ea01ad.
This reverts commit e1da704f67f34022b7aaf3afe277c86217844114.
This reverts commit c002c7ea9c5a3dbeb665e4070d852e6724d1ff86.

TBR=palmer@chromium.org,jam@chromium.org
BUG=325351,462306
==========

to

==========
Revert 3 CLs for shouldOverrideUrlLoading implementation.

Since https://codereview.chromium.org/1424263003 does not handle
overriding about:blank loads (or rather, about:blank loads are
handled synchronously and can thus be finished before we have a chance
to override them) we cannot land that patch without potentially breaking
lots of apps using WebView.

The second CL being reverted is a fix for the first one to post
didStopLoad and didFailLoad in the correct order.

The third CL being reverted here is a small change removing code that
is not used by https://codereview.chromium.org/1424263003 but is used
now that we revert that CL.

This reverts commit bae3ff13e6959b713b872df3c4a734d6a1ea01ad.
This reverts commit e1da704f67f34022b7aaf3afe277c86217844114.
This reverts commit c002c7ea9c5a3dbeb665e4070d852e6724d1ff86.

TBR=palmer@chromium.org,jam@chromium.org
BUG=325351,462306
==========

[commit-bot: I haz the power, 2016-01-12 11:07:41]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-12 11:08:22]

Description was changed from

==========
Revert 3 CLs for shouldOverrideUrlLoading implementation.

Since https://codereview.chromium.org/1424263003 does not handle
overriding about:blank loads (or rather, about:blank loads are
handled synchronously and can thus be finished before we have a chance
to override them) we cannot land that patch without potentially breaking
lots of apps using WebView.

The second CL being reverted is a fix for the first one to post
didStopLoad and didFailLoad in the correct order.

The third CL being reverted here is a small change removing code that
is not used by https://codereview.chromium.org/1424263003 but is used
now that we revert that CL.

This reverts commit bae3ff13e6959b713b872df3c4a734d6a1ea01ad.
This reverts commit e1da704f67f34022b7aaf3afe277c86217844114.
This reverts commit c002c7ea9c5a3dbeb665e4070d852e6724d1ff86.

TBR=palmer@chromium.org,jam@chromium.org
BUG=325351,462306
==========

to

==========
Revert 3 CLs for shouldOverrideUrlLoading implementation.

Since https://codereview.chromium.org/1424263003 does not handle
overriding about:blank loads (or rather, about:blank loads are
handled synchronously and can thus be finished before we have a chance
to override them) we cannot land that patch without potentially breaking
lots of apps using WebView.

The second CL being reverted is a fix for the first one to post
didStopLoad and didFailLoad in the correct order.

The third CL being reverted here is a small change removing code that
is not used by https://codereview.chromium.org/1424263003 but is used
now that we revert that CL.

This reverts commit bae3ff13e6959b713b872df3c4a734d6a1ea01ad.
This reverts commit e1da704f67f34022b7aaf3afe277c86217844114.
This reverts commit c002c7ea9c5a3dbeb665e4070d852e6724d1ff86.

TBR=palmer@chromium.org,jam@chromium.org
BUG=325351,462306

Committed: https://crrev.com/68afca713e53e857cbc6c2d25aeb0bb1d76cd4ac
Cr-Commit-Position: refs/heads/master@{#368849}
==========

[commit-bot: I haz the power, 2016-01-12 11:08:23]

Patchset 3 (id:??) landed as
https://crrev.com/68afca713e53e857cbc6c2d25aeb0bb1d76cd4ac
Cr-Commit-Position: refs/heads/master@{#368849}