Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issue 1530153006: Revert of Add AdobeRGB1998 Munsell chart layout test (Closed)

Created:
5 years ago by Noel Gordon
Modified:
5 years ago
Reviewers:
Justin Novosad
CC:
chromium-reviews, blink-reviews, radu.velea
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add AdobeRGB1998 Munsell chart layout test (patchset #1 id:1 of https://codereview.chromium.org/1531803002/ ) Reason for revert: Reverting this due to back-end infra problems creating rebaselines. Original issue's description: > Add AdobeRGB1998 Munsell chart layout test > > Like the sRGB-to-sRGB Munsell chart test, but wider-gamut. Add a > Munsell chart AdobeRGB1998 to sRGB color transform test. > > The test is designed to run in the test harness or manually, and > tabulates the dE (per color error from the expected Munsell sRGB > colors [1]) and total RMS color error. > > Since a color transform is applied, this test may produce output > colors different from the expected colors, but the RMS error (or > score) is what matters. Scores below 2 (2 is the level of a Just > Noticeable Difference [JND]) are considered good, and good color > correction libraries score well below that on this test [2]. > > [1] For more details on Munsell colors and gamuts, see > http://www.brucelindbloom.com/index.html?ColorCheckerRGB.html > > [2] http://bit.ly/1Gkadze Adobe to sRGB chart tests, QCMS scores > less than 0.9 on this test. A similar test has been added to our > QCMS tests, issue 532910. > > BUG=570317 > > Committed: https://crrev.com/41e148e07880590674f5eaf1ba8145da8938709a > Cr-Commit-Position: refs/heads/master@{#365715} TBR=junov@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=570317 Committed: https://crrev.com/8fbe3a9190b3ea1d48908d88289541af88167c27 Cr-Commit-Position: refs/heads/master@{#365734}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -38 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/images/color-profile-munsell-adobe-to-srgb.html View 1 chunk +0 lines, -36 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Noel Gordon
Created Revert of Add AdobeRGB1998 Munsell chart layout test
5 years ago (2015-12-17 03:53:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1530153006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1530153006/1
5 years ago (2015-12-17 03:53:40 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-17 03:56:26 UTC) #3
commit-bot: I haz the power
5 years ago (2015-12-17 03:57:40 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8fbe3a9190b3ea1d48908d88289541af88167c27
Cr-Commit-Position: refs/heads/master@{#365734}

Powered by Google App Engine
This is Rietveld 408576698