Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Unified Diff: third_party/WebKit/Source/core/dom/Document.h

Issue 1530153002: Change how DOM Inspector fetches document's base URL. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added documentation. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/Document.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/dom/Document.h
diff --git a/third_party/WebKit/Source/core/dom/Document.h b/third_party/WebKit/Source/core/dom/Document.h
index 494e168859b82ff2ead42a8cbb8c1edacff0fdd2..9f854f48fd36a116f574368d4af6a804f68889e3 100644
--- a/third_party/WebKit/Source/core/dom/Document.h
+++ b/third_party/WebKit/Source/core/dom/Document.h
@@ -518,8 +518,19 @@ public:
const AtomicString& baseTarget() const { return m_baseTarget; }
void processBaseElement();
+ // Creates URL based on passed relative url and this documents base URL.
+ // Depending on base URL value it is possible that parent document
+ // base URL will be used instead. Uses completeURLWithOverride internally.
KURL completeURL(const String&) const;
+ // Creates URL based on passed relative url and passed base URL override.
+ // Depending on baseURLOverride value it is possible that parent document
+ // base URL will be used instead of it. See baseURLForOverride function
+ // for details.
KURL completeURLWithOverride(const String&, const KURL& baseURLOverride) const;
+ // Determines which base URL should be used given specified override.
+ // If override is empty or is about:blank url and parent document exists
+ // base URL of parent will be returned, passed base URL override otherwise.
+ const KURL& baseURLForOverride(const KURL& baseURLOverride) const;
String userAgent() const final;
void disableEval(const String& errorMessage) final;
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/Document.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698