Change how DOM Inspector fetches document's base URL.

third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp

 /*
  * Copyright (C) 2009 Apple Inc. All rights reserved.
  * Copyright (C) 2011 Google Inc. All rights reserved.
  * Copyright (C) 2009 Joseph Pecoraro
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
@@ skipping 1457 matching lines @@
 // static
 String InspectorDOMAgent::documentURLString(Document* document)
 {
     if (!document || document->url().isNull())
         return "";
     return document->url().string();
 }
 
 static String documentBaseURLString(Document* document)
 {
-    return document->completeURL("").string();
+    return document->baseURLForOverride(document->baseURL()).string();

[dgozman, 2015/12/16 18:00:49]

This change looks fine, but I'm not sure about baseURLForOverride naming and
changes in Document in general. Over to tkent@.

[mharanczyk, 2015/12/16 18:29:42]

I'm open for suggestions about naming, I'm not happy with it either.
I tried to preserve old code paths without duplicating code/logic, but maybe it
is enough to just return document->baseURL().string()? Doing empty string
completeURL magic can lead to some unfortunate failures when all Inspector wants
in baseURL.

[sof, 2015/12/16 18:53:27]

Will this not return the parent document's base url if document->baseURL() is
about:blank? that is not what's wanted here.

 }
 
 static TypeBuilder::DOM::ShadowRootType::Enum shadowRootType(ShadowRoot* shadowRoot)
 {
     switch (shadowRoot->type()) {
     case ShadowRootType::UserAgent:
         return TypeBuilder::DOM::ShadowRootType::User_agent;
     case ShadowRootType::V0:
     case ShadowRootType::Open:
         return TypeBuilder::DOM::ShadowRootType::Open;
@@ skipping 666 matching lines @@
     visitor->trace(m_document);
     visitor->trace(m_revalidateTask);
     visitor->trace(m_searchResults);
 #endif
     visitor->trace(m_history);
     visitor->trace(m_domEditor);
     InspectorBaseAgent::trace(visitor);
 }
 
 } // namespace blink