[turbofan] Fix ASAN bug in escape analysis

src/compiler/escape-analysis.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/escape-analysis.h"
 
 #include "src/base/flags.h"
 #include "src/bootstrapper.h"
 #include "src/compilation-dependencies.h"
 #include "src/compiler/common-operator.h"
@@ skipping 436 matching lines @@
       info_(zone),
       queue_(zone) {
   info_.resize(graph->NodeCount());
 }
 
 
 EscapeStatusAnalysis::~EscapeStatusAnalysis() {}
 
 
 bool EscapeStatusAnalysis::HasEntry(Node* node) {
+  info_.resize(graph()->NodeCount());

[Benedikt Meurer, 2015/12/16 17:53:56]

How about

if (node->id() >= info_.size()) return false;

as in IsVirtual below?

[sigurds, 2015/12/17 10:16:32]

I want to get rid of the checks here, see comments in new patchset.

   return info_[node->id()] != kUnknown;
 }
 
 
 bool EscapeStatusAnalysis::IsVirtual(Node* node) {
   if (node->id() >= info_.size()) {
     return false;
   }
   return info_[node->id()] == kVirtual;
 }
 
 
 bool EscapeStatusAnalysis::IsEscaped(Node* node) {
   return info_[node->id()] == kEscaped;

[Benedikt Meurer, 2015/12/16 17:53:56]

Isn't this subject to the same issue?

[sigurds, 2015/12/17 10:16:32]

See comments in new patch set.

 }
 
 
 bool EscapeStatusAnalysis::IsAllocation(Node* node) {
   return node->opcode() == IrOpcode::kAllocate ||
          node->opcode() == IrOpcode::kFinishRegion;
 }
 
 
 bool EscapeStatusAnalysis::SetEscaped(Node* node) {
@@ skipping 824 matching lines @@
     }
   }
   for (size_t n = 0; n < object_states.size(); n++) {
     DebugPrintState(object_states[n]);
   }
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8