Support source maps in server mode

Support source maps in server mode

R=jmesserly@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/bbed6ea39790462e7263a479a8790c62d10f311b

[vsm, 2015-12-16 15:07:00]

vsm@google.com changed reviewers:
+ jmesserly@google.com

[Jennifer Messerly, 2015-12-16 18:40:07]

lgtm

https://codereview.chromium.org/1530133003/diff/1/lib/src/codegen/js_codegen....
File lib/src/codegen/js_codegen.dart (right):

https://codereview.chromium.org/1530133003/diff/1/lib/src/codegen/js_codegen....
lib/src/codegen/js_codegen.dart:3504: var serverUrl = flags.serverMode ?
'http://${flags.host}:${flags.port}/' : null;
format?

https://codereview.chromium.org/1530133003/diff/1/lib/src/codegen/js_printer....
File lib/src/codegen/js_printer.dart (right):

https://codereview.chromium.org/1530133003/diff/1/lib/src/codegen/js_printer....
lib/src/codegen/js_printer.dart:82: SourceMapPrintingContext(this.printer,
this.outputDir, this.inputDir, this.serverUrl);
slight factoring thing, I wonder if we should pass in something that can do URI
mapping for us (AbstractCompiler?), rather than have SourceMapPrintingContext
know about server details?

I've been slowly trying to disentangle server from the rest of the code base, in
the hopes that we can remove it in favor of a file watcher as the primary dev
experience.

https://codereview.chromium.org/1530133003/diff/1/lib/src/codegen/js_printer....
lib/src/codegen/js_printer.dart:124: return new Uri(path: serverUrl +
path.relative(src.path, from: inputDir));
the name here's a little confusing, if this was a full "serverUrl" I don't think
it would make sense to put it in the "path" part of the Uri. I guess it's the
"servePath", e.g. if server Url is http://localhost:8080/foo/bar, this is the
"foo/bar/" part?

[vsm, 2016-01-07 21:22:03]

https://codereview.chromium.org/1530133003/diff/1/lib/src/codegen/js_codegen....
File lib/src/codegen/js_codegen.dart (right):

https://codereview.chromium.org/1530133003/diff/1/lib/src/codegen/js_codegen....
lib/src/codegen/js_codegen.dart:3504: var serverUrl = flags.serverMode ?
'http://${flags.host}:${flags.port}/' : null;
On 2015/12/16 18:40:07, John Messerly wrote:
> format?

Done.

https://codereview.chromium.org/1530133003/diff/1/lib/src/codegen/js_printer....
File lib/src/codegen/js_printer.dart (right):

https://codereview.chromium.org/1530133003/diff/1/lib/src/codegen/js_printer....
lib/src/codegen/js_printer.dart:82: SourceMapPrintingContext(this.printer,
this.outputDir, this.inputDir, this.serverUrl);
On 2015/12/16 18:40:07, John Messerly wrote:
> slight factoring thing, I wonder if we should pass in something that can do
URI
> mapping for us (AbstractCompiler?), rather than have SourceMapPrintingContext
> know about server details?
> 
> I've been slowly trying to disentangle server from the rest of the code base,
in
> the hopes that we can remove it in favor of a file watcher as the primary dev
> experience.

added a todo

https://codereview.chromium.org/1530133003/diff/1/lib/src/codegen/js_printer....
lib/src/codegen/js_printer.dart:124: return new Uri(path: serverUrl +
path.relative(src.path, from: inputDir));
On 2015/12/16 18:40:07, John Messerly wrote:
> the name here's a little confusing, if this was a full "serverUrl" I don't
think
> it would make sense to put it in the "path" part of the Uri. I guess it's the
> "servePath", e.g. if server Url is http://localhost:8080/foo/bar, this is the
> "foo/bar/" part?

i think i was abusing the path argument to the Uri constructor.  redid this more
cleanly.

[vsm, 2016-01-07 21:22:14]

Description was changed from

==========
Support source maps in server mode
==========

to

==========
Support source maps in server mode

R=jmesserly@google.com

Committed:
https://github.com/dart-lang/dev_compiler/commit/bbed6ea39790462e7263a479a879...
==========

[vsm, 2016-01-07 21:22:15]

Committed patchset #2 (id:20001) manually as
bbed6ea39790462e7263a479a8790c62d10f311b (presubmit successful).