Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: chrome/browser/browsing_data/browsing_data_counter_utils.h

Issue 1530123002: Prepare ClearBrowsingDataDialogFragment for browsing data counters. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@utils
Patch Set: Added *Bridge class, shared enum Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browsing_data/browsing_data_counter_utils.h
diff --git a/chrome/browser/browsing_data/browsing_data_counter_utils.h b/chrome/browser/browsing_data/browsing_data_counter_utils.h
index df73472af15951eedee577206eb47fb5a86436df..8b95d30e1cdc950c8d5e84f4d14446fd41f3bb9d 100644
--- a/chrome/browser/browsing_data/browsing_data_counter_utils.h
+++ b/chrome/browser/browsing_data/browsing_data_counter_utils.h
@@ -15,6 +15,25 @@ bool AreCountersEnabled();
base::string16 GetCounterTextFromResult(
const BrowsingDataCounter::Result* result);
+// Browsing data types as seen in the Android UI.
+//
+// A Java counterpart will be generated for this enum.
+// GENERATED_JAVA_ENUM_PACKAGE: org.chromium.chrome.browser
+enum ClankBrowsingDataType {
newt (away) 2016/01/12 18:55:26 Don't use the word "clank" in code. How about just
msramek 2016/01/13 15:27:53 Done. Yes, I wasn't sure about that, but I found s
+ HISTORY,
+ CACHE,
+ COOKIES,
+ PASSWORDS,
+ FORM_DATA,
+ BOOKMARKS,
+ NUM_TYPES = BOOKMARKS
newt (away) 2016/01/12 18:55:26 remove " = BOOKMARKS". In this case, BOOKMARKS wil
msramek 2016/01/13 15:27:53 Ah, of course.
+};
+
+// Copies the name of the deletion preference corresponding to the given
+// |data_type| to |out_pref|. Returns false if no such preference exists.
+bool GetDeletionPreferenceFromDataType(
+ ClankBrowsingDataType data_type, std::string* out_pref);
+
// Creates a new instance of BrowsingDataCounter that is counting the data
// related to a given deletion preference |pref_name|.
BrowsingDataCounter* CreateCounterForPreference(std::string pref_name);

Powered by Google App Engine
This is Rietveld 408576698