Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2802)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/sync/ui/ClearSyncDataDialogFragment.java

Issue 1530123002: Prepare ClearBrowsingDataDialogFragment for browsing data counters. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@utils
Patch Set: s/default/NUM_TYPES/ Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/sync/ui/ClearSyncDataDialogFragment.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/sync/ui/ClearSyncDataDialogFragment.java b/chrome/android/java/src/org/chromium/chrome/browser/sync/ui/ClearSyncDataDialogFragment.java
index 56cd8e763909fd22f2ff697b2d21e6529287c0fa..14ad82c823ccbc679471ff9a32a9f760663bf7ba 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/sync/ui/ClearSyncDataDialogFragment.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/sync/ui/ClearSyncDataDialogFragment.java
@@ -12,8 +12,6 @@ import org.chromium.chrome.browser.ChromeBrowserProviderClient;
import org.chromium.chrome.browser.preferences.privacy.ClearBrowsingDataDialogFragment;
import org.chromium.chrome.browser.signin.SigninManager;
-import java.util.EnumSet;
-
/**
* Modal dialog for clearing sync data. This allows the user to clear browsing data as well as
* other synced data types like bookmarks.
@@ -33,12 +31,12 @@ public class ClearSyncDataDialogFragment extends ClearBrowsingDataDialogFragment
}
@Override
- protected EnumSet<DialogOption> getDefaultDialogOptionsSelections() {
- return EnumSet.allOf(DialogOption.class);
+ protected boolean isOptionSelectedByDefault(DialogOption option) {
+ return true;
}
@Override
- protected void onOptionSelected(final EnumSet<DialogOption> optionsSelected) {
+ protected void onOptionSelected() {
if (mApplicationContext == null) return;
showProgressDialog();
@@ -51,7 +49,7 @@ public class ClearSyncDataDialogFragment extends ClearBrowsingDataDialogFragment
new AsyncTask<Void, Void, Void>() {
@Override
protected Void doInBackground(Void... arg0) {
- if (optionsSelected.contains(DialogOption.CLEAR_BOOKMARKS_DATA)) {
+ if (getSelectedOptions().contains(DialogOption.CLEAR_BOOKMARKS_DATA)) {
ChromeBrowserProviderClient.removeAllUserBookmarks(mApplicationContext);
}
return null;
@@ -59,9 +57,9 @@ public class ClearSyncDataDialogFragment extends ClearBrowsingDataDialogFragment
@Override
protected void onPostExecute(Void result) {
- clearBrowsingData(optionsSelected);
+ clearBrowsingData();
- if (optionsSelected.contains(DialogOption.CLEAR_BOOKMARKS_DATA)) {
+ if (getSelectedOptions().contains(DialogOption.CLEAR_BOOKMARKS_DATA)) {
// onPostExecute is back in the UI thread.
SigninManager.get(mApplicationContext).clearLastSignedInUser();
}

Powered by Google App Engine
This is Rietveld 408576698