Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(750)

Side by Side Diff: chrome/browser/android/browsing_data/browsing_data_counter_bridge.h

Issue 1530123002: Prepare ClearBrowsingDataDialogFragment for browsing data counters. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@utils
Patch Set: Added *Bridge class, shared enum Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef CHROME_BROWSER_ANDROID_BROWSING_DATA_BROWSING_DATA_COUNTER_BRIDGE_H_
6 #define CHROME_BROWSER_ANDROID_BROWSING_DATA_BROWSING_DATA_COUNTER_BRIDGE_H_
7
8 #include "base/android/jni_weak_ref.h"
9 #include "base/android/scoped_java_ref.h"
10 #include "chrome/browser/browsing_data/browsing_data_counter.h"
11
12 class Profile;
13
14 // This class is a wrapper for BrowsingDataCounter (C++ backend) to be used by
15 // ClearBrowsingDataFragment (Java UI).
16 class BrowsingDataCounterBridge {
17 public:
18 BrowsingDataCounterBridge(
newt (away) 2016/01/12 18:55:26 Document this. In particular, what are valid value
msramek 2016/01/13 15:27:53 Done. Also, renamed to |data_type|, since this is
19 JNIEnv* env,
20 const base::android::JavaParamRef<jobject>& obj,
21 jint dataType);
22
23 ~BrowsingDataCounterBridge();
24
25 // Called by the Java counterpart when it is getting garbage collected.
26 void Destroy(JNIEnv* env, const base::android::JavaParamRef<jobject>& obj);
27
28 void Callback(scoped_ptr<BrowsingDataCounter::Result> result);
newt (away) 2016/01/12 18:55:26 Should this method be private? Also, Callback is a
msramek 2016/01/13 15:27:53 Done. Renamed to |OnCounterFinished|, as that is t
29
30 bool valid() { return counter_; }
newt (away) 2016/01/12 18:55:26 Where is this method called?
msramek 2016/01/13 15:27:53 Hmm, good catch. I know that I added here to test
31
32 private:
33 base::android::ScopedJavaGlobalRef<jobject> jobject_;
34 scoped_ptr<BrowsingDataCounter> counter_;
35
36 DISALLOW_COPY_AND_ASSIGN(BrowsingDataCounterBridge);
37 };
38
39 bool RegisterBrowsingDataCounterBridge(JNIEnv* env);
40
41 #endif // CHROME_BROWSER_ANDROID_BROWSING_DATA_BROWSING_DATA_COUNTER_BRIDGE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698