Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1529963002: Forward 31842. (Closed)

Created:
5 years ago by tonyg
Modified:
5 years ago
Reviewers:
ppi
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Forward 31842. Each additional mapping starts a new server on an incremented port. This patch allows two mappings to work. BUG= R=ppi@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/b2b646b5c9697feb70e41a15dfe750cb45ae0a9d

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M mojo/devtools/common/remote_adb_setup View 1 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
tonyg
5 years ago (2015-12-15 20:27:00 UTC) #3
ppi
lgtm https://codereview.chromium.org/1529963002/diff/1/mojo/devtools/common/remote_adb_setup File mojo/devtools/common/remote_adb_setup (right): https://codereview.chromium.org/1529963002/diff/1/mojo/devtools/common/remote_adb_setup#newcode49 mojo/devtools/common/remote_adb_setup:49: # 31841: http server for base mappings nit: ...
5 years ago (2015-12-15 21:24:30 UTC) #4
tonyg
Committed patchset #2 (id:20001) manually as b2b646b5c9697feb70e41a15dfe750cb45ae0a9d (presubmit successful).
5 years ago (2015-12-15 21:27:59 UTC) #6
tonyg
5 years ago (2015-12-15 21:28:02 UTC) #7
Message was sent while issue was closed. 
https://codereview.chromium.org/1529963002/diff/1/mojo/devtools/common/remote...
File mojo/devtools/common/remote_adb_setup (right):

https://codereview.chromium.org/1529963002/diff/1/mojo/devtools/common/remote...
mojo/devtools/common/remote_adb_setup:49: #   31841: http server for base
mappings
On 2015/12/15 21:24:30, ppi wrote:
> nit: maybe just 31841-31842: http servers for origin mappings

Done.

Powered by Google App Engine
This is Rietveld 408576698