Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1529923003: Moved the tests for the element model into locations corresponding to the implementation (Closed)

Created:
5 years ago by Brian Wilkerson
Modified:
5 years ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Moved the tests for the element model into locations corresponding to the implementation R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/66e07636f49d9e03a86b313fb55546d6a3fbc412

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -4068 lines) Patch
A pkg/analyzer/test/dart/element/element_test.dart View 1 chunk +30 lines, -0 lines 0 comments Download
A + pkg/analyzer/test/dart/element/test_all.dart View 1 chunk +6 lines, -8 lines 1 comment Download
A + pkg/analyzer/test/dart/test_all.dart View 1 chunk +5 lines, -7 lines 0 comments Download
D pkg/analyzer/test/generated/element_test.dart View 1 chunk +0 lines, -4019 lines 0 comments Download
M pkg/analyzer/test/generated/test_all.dart View 2 chunks +0 lines, -2 lines 0 comments Download
A + pkg/analyzer/test/src/dart/element/element_test.dart View 2 chunks +5 lines, -17 lines 0 comments Download
A + pkg/analyzer/test/src/dart/element/test_all.dart View 1 chunk +6 lines, -8 lines 0 comments Download
A + pkg/analyzer/test/src/dart/test_all.dart View 1 chunk +5 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
5 years ago (2015-12-16 14:19:36 UTC) #2
scheglov
LGTM https://codereview.chromium.org/1529923003/diff/1/pkg/analyzer/test/dart/element/test_all.dart File pkg/analyzer/test/dart/element/test_all.dart (right): https://codereview.chromium.org/1529923003/diff/1/pkg/analyzer/test/dart/element/test_all.dart#newcode15 pkg/analyzer/test/dart/element/test_all.dart:15: group('generated tests', () { Not actually "generated" anymore ...
5 years ago (2015-12-16 15:00:06 UTC) #3
Brian Wilkerson
5 years ago (2015-12-16 15:49:20 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
66e07636f49d9e03a86b313fb55546d6a3fbc412 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698