Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 1529903002: Adding some nullptr checks around calls to Canvas2DLayerBridge::getOrCreateSurface (Closed)

Created:
5 years ago by Justin Novosad
Modified:
5 years ago
Reviewers:
Stephen White
CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, ajuma+watch-canvas_chromium.org, dshwang, jbroman, Justin Novosad, danakj, blink-reviews-platform-graphics_chromium.org, Rik, f(malita), blink-reviews, vmpstr+blinkwatch_chromium.org, Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding some nullptr checks around calls to Canvas2DLayerBridge::getOrCreateSurface This change is to make canvas more resilient to memory allocation failures and GPU context losses by dropping content instead of crashing the render process. BUG=569971 Committed: https://crrev.com/c014bf5e07c6d9f7e2b4945b95d762b296177675 Cr-Commit-Position: refs/heads/master@{#365331}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp View 4 chunks +9 lines, -7 lines 1 comment Download

Depends on Patchset:

Messages

Total messages: 8 (3 generated)
Justin Novosad
PTAL https://codereview.chromium.org/1529903002/diff/1/third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp File third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp (left): https://codereview.chromium.org/1529903002/diff/1/third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp#oldcode566 third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp:566: if (!checkSurfaceValid()) This check is expensive and was ...
5 years ago (2015-12-15 18:55:55 UTC) #2
Stephen White
LGTM
5 years ago (2015-12-15 19:06:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1529903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1529903002/1
5 years ago (2015-12-15 19:10:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-15 21:32:00 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-15 21:32:43 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c014bf5e07c6d9f7e2b4945b95d762b296177675
Cr-Commit-Position: refs/heads/master@{#365331}

Powered by Google App Engine
This is Rietveld 408576698