Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 1529883004: gyp: always use pkg-config wrapper (Closed)

Created:
5 years ago by Sam Clegg
Modified:
5 years ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gyp: always use pkg-config wrapper Without this the sysroot is not honored and pkg-config always finds the host's .pc file. BUG=569947 Committed: https://crrev.com/f83a08c9c9156960d505472108a5c96ee2972820 Cr-Commit-Position: refs/heads/master@{#365707}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -21 lines) Patch
M build/linux/system.gyp View 7 chunks +21 lines, -21 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Sam Clegg
5 years ago (2015-12-16 18:39:38 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1529883004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1529883004/1
5 years ago (2015-12-16 18:40:15 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-16 19:52:21 UTC) #8
Dirk Pranke
lgtm
5 years ago (2015-12-17 01:23:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1529883004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1529883004/1
5 years ago (2015-12-17 02:36:28 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-17 03:20:54 UTC) #13
commit-bot: I haz the power
5 years ago (2015-12-17 03:22:53 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f83a08c9c9156960d505472108a5c96ee2972820
Cr-Commit-Position: refs/heads/master@{#365707}

Powered by Google App Engine
This is Rietveld 408576698