Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Unified Diff: net/quic/quic_packet_creator.h

Issue 1529843002: Remove needs_padding from QuicPacketCreator AddFrame. Non functional change. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@109634576
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/quic/quic_packet_creator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_packet_creator.h
diff --git a/net/quic/quic_packet_creator.h b/net/quic/quic_packet_creator.h
index f06e55a6efb23c9c0328efa0f110e911119e269f..8c747066adf09e48fa4cc220fe78ec3436b43d05 100644
--- a/net/quic/quic_packet_creator.h
+++ b/net/quic/quic_packet_creator.h
@@ -311,13 +311,10 @@ class NET_EXPORT_PRIVATE QuicPacketCreator {
bool fec_flag,
QuicPacketHeader* header);
- // Allows a frame to be added without creating retransmittable frames.
- // Particularly useful for retransmits using SerializeAllFrames().
- // If current open packet cannot accommodate |frame|, returns false and
- // flushes all pending frames.
- bool AddFrame(const QuicFrame& frame,
- bool save_retransmittable_frames,
- bool needs_padding);
+ // Adds a |frame| if there is space and returns false and flushes all pending
+ // frames if there isn't room. If |save_retransmittable_frames| is true,
+ // saves the |frame| in the next SerializedPacket.
+ bool AddFrame(const QuicFrame& frame, bool save_retransmittable_frames);
// Adds a padding frame to the current packet only if the current packet
// contains a handshake message, and there is sufficient room to fit a
« no previous file with comments | « no previous file | net/quic/quic_packet_creator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698