Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1529823002: [json parser] remove dead code path. (Closed)

Created:
5 years ago by Yang
Modified:
5 years ago
Reviewers:
Jarin, adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[json parser] remove dead code path. R=jarin@chromium.org Committed: https://crrev.com/0a1e909f4380aceff05ea0102763adabf0c87203 Cr-Commit-Position: refs/heads/master@{#32884}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -11 lines) Patch
M src/parsing/json-parser.h View 1 chunk +2 lines, -11 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Yang
5 years ago (2015-12-15 14:17:06 UTC) #1
Jarin
lgtm
5 years ago (2015-12-15 14:25:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1529823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1529823002/1
5 years ago (2015-12-15 14:30:47 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/8981)
5 years ago (2015-12-15 14:44:28 UTC) #6
Yang
Adam, owners review please.
5 years ago (2015-12-15 14:46:36 UTC) #8
adamk
lgtm
5 years ago (2015-12-16 08:15:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1529823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1529823002/1
5 years ago (2015-12-16 08:36:55 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-16 08:38:14 UTC) #12
commit-bot: I haz the power
5 years ago (2015-12-16 08:39:05 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0a1e909f4380aceff05ea0102763adabf0c87203
Cr-Commit-Position: refs/heads/master@{#32884}

Powered by Google App Engine
This is Rietveld 408576698