Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Unified Diff: src/snapshot/natives-external.cc

Issue 1529763002: [serializer] remove some dead code. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/snapshot/serialize.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/snapshot/natives-external.cc
diff --git a/src/snapshot/natives-external.cc b/src/snapshot/natives-external.cc
index 59d4be72dd9e42a65b62b90fee0efe57362d11a5..a97b0a74423f4001de8a4db79f41cca04adf5016 100644
--- a/src/snapshot/natives-external.cc
+++ b/src/snapshot/natives-external.cc
@@ -93,23 +93,17 @@ class NativesStore {
return Vector<const char>::cast(name);
}
- bool ReadNameAndContentPair(SnapshotByteSource* bytes) {
+ void ReadNameAndContentPair(SnapshotByteSource* bytes) {
const byte* id;
- int id_length;
const byte* source;
- int source_length;
- bool success = bytes->GetBlob(&id, &id_length) &&
- bytes->GetBlob(&source, &source_length);
- if (success) {
- Vector<const char> id_vector(reinterpret_cast<const char*>(id),
- id_length);
- Vector<const char> source_vector(
- reinterpret_cast<const char*>(source), source_length);
- native_ids_.Add(id_vector);
- native_source_.Add(source_vector);
- native_names_.Add(NameFromId(id, id_length));
- }
- return success;
+ int id_length = bytes->GetBlob(&id);
+ int source_length = bytes->GetBlob(&source);
+ Vector<const char> id_vector(reinterpret_cast<const char*>(id), id_length);
+ Vector<const char> source_vector(reinterpret_cast<const char*>(source),
+ source_length);
+ native_ids_.Add(id_vector);
+ native_source_.Add(source_vector);
+ native_names_.Add(NameFromId(id, id_length));
}
List<Vector<const char> > native_ids_;
« no previous file with comments | « no previous file | src/snapshot/serialize.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698