Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1529763002: [serializer] remove some dead code. (Closed)

Created:
5 years ago by Yang
Modified:
5 years ago
Reviewers:
vogelheim
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[serializer] remove some dead code. credits to gcov. R=vogelheim@chromium.org Committed: https://crrev.com/44e401f18c35f37ec02ba924b0fe2350200c79fc Cr-Commit-Position: refs/heads/master@{#32859}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -45 lines) Patch
M src/snapshot/natives-external.cc View 1 chunk +9 lines, -15 lines 0 comments Download
M src/snapshot/serialize.h View 2 chunks +0 lines, -6 lines 0 comments Download
M src/snapshot/snapshot-source-sink.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/snapshot/snapshot-source-sink.cc View 1 chunk +5 lines, -20 lines 0 comments Download
M test/cctest/test-serialize.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Yang
5 years ago (2015-12-15 10:15:39 UTC) #1
vogelheim
lgtm. Nice!
5 years ago (2015-12-15 10:20:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1529763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1529763002/1
5 years ago (2015-12-15 10:23:43 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-15 11:01:15 UTC) #5
commit-bot: I haz the power
5 years ago (2015-12-15 11:01:24 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/44e401f18c35f37ec02ba924b0fe2350200c79fc
Cr-Commit-Position: refs/heads/master@{#32859}

Powered by Google App Engine
This is Rietveld 408576698