Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 1529743002: Revert of [Blob] Fix for resetting reader. (Closed)

Created:
5 years ago by yoichio
Modified:
5 years ago
Reviewers:
michaeln, mmenke, dmurph
CC:
chromium-reviews, darin-cc_chromium.org, jam, kinuko+fileapi, nhiroki, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Blob] Fix for resetting reader. (patchset #8 id:130001 of https://codereview.chromium.org/1513783005/ ) Reason for revert: CL was duplicated and compile failed. https://build.chromium.org/p/chromium.mac/builders/Mac%20GN/builds/22509 https://chromium.googlesource.com/chromium/src/+log/ebf7a6b19a7a468195a5606fbd2bbd6d07a26ea2 Original issue's description: > [Blob] Fix for resetting reader. > > R=michaeln > BUG=567692 > > Committed: https://crrev.com/ebf7a6b19a7a468195a5606fbd2bbd6d07a26ea2 > Cr-Commit-Position: refs/heads/master@{#365177} TBR=michaeln@chromium.org,mmenke@chromium.org,dmurph@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=567692 Committed: https://crrev.com/1c3ff0ea380d91301215c7bfe966b992e62c2bdb Cr-Commit-Position: refs/heads/master@{#365183}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -74 lines) Patch
M content/browser/loader/upload_data_stream_builder.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/loader/upload_data_stream_builder_unittest.cc View 1 chunk +0 lines, -51 lines 0 comments Download
M storage/browser/blob/upload_blob_element_reader.h View 4 chunks +3 lines, -12 lines 0 comments Download
M storage/browser/blob/upload_blob_element_reader.cc View 1 chunk +3 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
yoichio
Created Revert of [Blob] Fix for resetting reader.
5 years ago (2015-12-15 06:38:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1529743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1529743002/1
5 years ago (2015-12-15 06:39:17 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-15 06:40:39 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1c3ff0ea380d91301215c7bfe966b992e62c2bdb Cr-Commit-Position: refs/heads/master@{#365183}
5 years ago (2015-12-15 06:41:47 UTC) #5
henrika (OOO until Aug 14)
5 years ago (2015-12-15 11:34:45 UTC) #6
Message was sent while issue was closed.
Don't have the complete history here but your work seems to have cleared up most
issues but we still se
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/2...
even with your revert. Not sure why.

Powered by Google App Engine
This is Rietveld 408576698