Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3673)

Unified Diff: chrome/browser/ui/BUILD.gn

Issue 1529723002: [MacViews] Get unit_tests linking. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mvbb
Patch Set: Fix mac_views_browser!=1 link. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/chrome_tests_unit.gypi » ('j') | chrome/chrome_tests_unit.gypi » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/BUILD.gn
diff --git a/chrome/browser/ui/BUILD.gn b/chrome/browser/ui/BUILD.gn
index 91825ea9297fd10277fad7138a38ea35ee4888aa..067325e3fa5be704ba600e96a96f55029bd3dc6c 100644
--- a/chrome/browser/ui/BUILD.gn
+++ b/chrome/browser/ui/BUILD.gn
@@ -555,8 +555,8 @@ source_set("test_support") {
sources = [
"browser.h",
- "cocoa/extensions/browser_action_test_util_mac.mm",
- "cocoa/find_bar/find_bar_host_unittest_util_cocoa.mm",
+ "cocoa/cocoa_test_helper.h",
+ "cocoa/cocoa_test_helper.mm",
"cocoa/run_loop_testing.h",
"cocoa/run_loop_testing.mm",
"exclusive_access/fullscreen_controller_state_test.cc",
@@ -601,6 +601,13 @@ source_set("test_support") {
]
}
+ if (is_mac && !mac_views_browser) {
tapted 2015/12/17 01:49:19 can this just be an `else` clause of `if (toolkit_
jackhou1 2015/12/17 04:03:50 Done.
+ sources += [
+ "cocoa/extensions/browser_action_test_util_mac.mm",
+ "cocoa/find_bar/find_bar_host_unittest_util_cocoa.mm",
+ ]
+ }
+
public_deps = [
":ui",
]
« no previous file with comments | « no previous file | chrome/chrome_tests_unit.gypi » ('j') | chrome/chrome_tests_unit.gypi » ('J')

Powered by Google App Engine
This is Rietveld 408576698