Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5542)

Unified Diff: chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm

Issue 1529713002: Update BaseBubbleController's dealloc function to use (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: updated BaseBubbleController's dealloc function to use unregisterFromNotifications and updated code that uses it Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/cocoa/base_bubble_controller.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm
diff --git a/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm b/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm
index 9b57585f54115f7b6386b460fd17ad14f4c5e206..b9b7ffb76ccea836dc317cb2a50bb542d2d4c7f5 100644
--- a/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm
+++ b/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm
@@ -254,6 +254,7 @@ class MenuDelegate : public ui::SimpleMenuModel::Delegate {
}
- (void)windowWillClose:(NSNotification*)notification {
+ [[NSNotificationCenter defaultCenter] removeObserver:self];
Robert Sesek 2015/12/15 15:19:36 This should be for only the specific notification
juncai 2015/12/15 17:43:55 Done.
bridge_->OnBubbleClosing();
[super windowWillClose:notification];
}
« no previous file with comments | « chrome/browser/ui/cocoa/base_bubble_controller.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698