Issue 1529703003: [EXPERIMENT] [MacViews] Enable and handle the profile switcher.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1529703003: [EXPERIMENT] [MacViews] Enable and handle the profile switcher.

Created:
5 years ago by tapted

Modified:
4 years, 6 months ago

Reviewers:

CC:
chromium-reviews, tfarina

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[EXPERIMENT] [MacViews] Enable and handle the profile switcher. BrowserNonClientFrameView uses NewAvatarButton to implement the profile switcher. However, the button's behavior is handled in BNCFV's subclasses because they have different layout and hit-test logic. This CL adds the necessary logic to BrowserNonClientFrameViewMac. BUG=565989 patch from issue 1517073002 at patchset 80001 (http://crrev.com/1517073002#ps80001)

Patch Set 1 #

Patch Set 2 : first pass #

Patch Set 3 : fix mac compile. Todo: ash, glass, mus #

Patch Set 4 : Incorporate Jack changes from crrev/1535813003 +rebase #

Patch Set 5 : fix mac compile, nit #

Patch Set 6 : Speculative compile fixes #

Patch Set 7 : Fix windows (glass) compile #

Patch Set 8 : Fix test compile on Windows #

Patch Set 9 : Neater, fix invalidation. Fix mus compile maybe. #

Patch Set 10 : rebase on .. stuff #

Patch Set 11 : rebase on.. more stuff #

Patch Set 12 : rebase #

Patch Set 13 : Biiiig rebase #

Patch Set 14 : Another big rebase #

Patch Set 15 : Another big rebase (so tiny now \o/) #

Patch Set 16 : rebase #

Patch Set 17 : rebase, fix, hook up properly #

Patch Set 18 : rebase #

Patch Set 19 : More sharing - still need to figure out that lifetime glitch #

Patch Set 20 : rebase (r388542) #

Patch Set 21 : rebase (r395397) #

Patch Set 22 : rebase (r395397) #

Patch Set 23 : rebase #

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+107 lines, -30 lines)			Patch
M	chrome/browser/ui/views/frame/avatar_button_manager.h	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/frame/avatar_button_manager.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20	2 chunks	+14 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/frame/browser_non_client_frame_view_mac.h	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20	3 chunks	+14 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_non_client_frame_view_mac.mm	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21	7 chunks	+69 lines, -8 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_non_client_frame_view_mus.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20	1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/browser/ui/views/frame/glass_browser_frame_view.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22	2 chunks	+2 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/views/frame/opaque_browser_frame_view.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20	1 chunk	+4 lines, -12 lines	0 comments	Download