Translate (Linux): add after infobar UI for server side language detection

chrome/browser/ui/gtk/infobars/after_translate_infobar_gtk.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/gtk/infobars/after_translate_infobar_gtk.h"
 
 #include "base/bind.h"
 #include "base/message_loop.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/translate/translate_infobar_delegate.h"
@@ skipping 10 matching lines @@
       weak_factory_(this) {
 }
 
 AfterTranslateInfoBar::~AfterTranslateInfoBar() {
 }
 
 void AfterTranslateInfoBar::InitWidgets() {
   TranslateInfoBarBase::InitWidgets();
 
   bool swapped_language_combos = false;
+  bool autodetermined_source_language =
+      GetDelegate()->original_language_index() ==
+      TranslateInfoBarDelegate::kNoIndex;
+
   std::vector<string16> strings;
   TranslateInfoBarDelegate::GetAfterTranslateStrings(
-      &strings, &swapped_language_combos);
-  DCHECK(strings.size() == 3U);
+        &strings, &swapped_language_combos, autodetermined_source_language);
+  if (autodetermined_source_language)
+    DCHECK(strings.size() == 2U);
+  else
+    DCHECK(strings.size() == 3U);

[Peter Kasting, 2013/05/23 19:59:56]

Nit: Simpler and uses DCHECK_EQ():

  DCHECK_EQ(autodetermined_source_language ? 2U : 3U, strings.size());

[Takashi Toyoshima, 2013/05/27 06:07:51]

Done.

 
   GtkWidget* hbox = gtk_hbox_new(FALSE, ui::kControlSpacing);
   gtk_util::CenterWidgetInHBox(hbox_, hbox, false, 0);
 
   size_t original_language_index = GetDelegate()->original_language_index();
   size_t target_language_index = GetDelegate()->target_language_index();
   bool exclude_the_other = original_language_index != target_language_index;
 
-  GtkWidget* original_lang_combo = CreateLanguageCombobox(
-      original_language_index,
-      exclude_the_other ? target_language_index :
-                          TranslateInfoBarDelegate::kNoIndex);
-  Signals()->Connect(original_lang_combo, "changed",
-                     G_CALLBACK(&OnOriginalLanguageModifiedThunk), this);
+  GtkWidget* original_lang_combo = NULL;
+  if (!autodetermined_source_language) {
+    original_lang_combo = CreateLanguageCombobox(
+        original_language_index,
+        exclude_the_other ? target_language_index :
+                            TranslateInfoBarDelegate::kNoIndex);
+    Signals()->Connect(original_lang_combo, "changed",
+                       G_CALLBACK(&OnOriginalLanguageModifiedThunk), this);
+  }
   GtkWidget* target_lang_combo = CreateLanguageCombobox(
       target_language_index,
       exclude_the_other ? original_language_index :
                           TranslateInfoBarDelegate::kNoIndex);
   Signals()->Connect(target_lang_combo, "changed",
                      G_CALLBACK(&OnTargetLanguageModifiedThunk), this);
 
   gtk_box_pack_start(GTK_BOX(hbox), CreateLabel(UTF16ToUTF8(strings[0])),
                      FALSE, FALSE, 0);
   gtk_box_pack_start(GTK_BOX(hbox),

[Peter Kasting, 2013/05/23 19:59:56]

Nit: Strange wrapping.  How about:

  gtk_box_pack_start(
      GTK_BOX(hbox),
      (swapped_language_combos || autodetermined_source_language) ?
          target_lang_combo : original_lang_combo, FALSE, FALSE, 0);

(Optional: Can move "FALSE, FALSE, 0);" to a subsequent line indented even with
first arg.)

[Takashi Toyoshima, 2013/05/27 06:07:51]

Done.

-                     swapped_language_combos ? target_lang_combo :
-                                               original_lang_combo,
+                     (swapped_language_combos ||
+                      autodetermined_source_language) ? target_lang_combo :
+                                                        original_lang_combo,
                      FALSE, FALSE, 0);
   gtk_box_pack_start(GTK_BOX(hbox), CreateLabel(UTF16ToUTF8(strings[1])),
                      FALSE, FALSE, 0);
-  gtk_box_pack_start(GTK_BOX(hbox),
-                     swapped_language_combos ? original_lang_combo :
-                                               target_lang_combo,
-                     FALSE, FALSE, 0);
-  gtk_box_pack_start(GTK_BOX(hbox), CreateLabel(UTF16ToUTF8(strings[2])),
-                     FALSE, FALSE, 0);
+  if (!autodetermined_source_language) {
+    gtk_box_pack_start(GTK_BOX(hbox),
+                       swapped_language_combos ? original_lang_combo :
+                                                 target_lang_combo,
+                       FALSE, FALSE, 0);
+    gtk_box_pack_start(GTK_BOX(hbox), CreateLabel(UTF16ToUTF8(strings[2])),
+                       FALSE, FALSE, 0);
+  }
 
   GtkWidget* button = gtk_button_new_with_label(
       l10n_util::GetStringUTF8(IDS_TRANSLATE_INFOBAR_REVERT).c_str());
   Signals()->Connect(button, "clicked",
                      G_CALLBACK(&OnRevertPressedThunk), this);
   gtk_box_pack_start(GTK_BOX(hbox), button, FALSE, FALSE, 0);
 }
 
 bool AfterTranslateInfoBar::ShowOptionsMenuButton() const {
   return true;
@@ skipping 33 matching lines @@
   base::MessageLoop::current()->PostTask(
       FROM_HERE,
       base::Bind(&AfterTranslateInfoBar::SetTargetLanguage,
                  weak_factory_.GetWeakPtr(),
                  index));
 }
 
 void AfterTranslateInfoBar::OnRevertPressed(GtkWidget* sender) {
   GetDelegate()->RevertTranslation();
 }