Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1529643002: [Cronet] Use prebuilt Netty Http/2 server for Cronet BidirectionalStream testing. (Closed)

Created:
5 years ago by mef
Modified:
4 years, 10 months ago
Reviewers:
pauljensen, kapishnikov
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@bidi_impl_helen8
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prebuilt Netty Http/2 server for Cronet BidirectionalStream testing. BUG=516342

Patch Set 1 #

Patch Set 2 : Prebuilt Netty Http/2 server for Cronet BidirectionalStream testing. #

Patch Set 3 : Use local build of Netty TCNative (https://codereview.chromium.org/1537473002/) #

Patch Set 4 : Sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+424 lines, -0 lines) Patch
M components/cronet.gypi View 1 2 3 2 chunks +6 lines, -0 lines 0 comments Download
A components/cronet/android/test/src/org/chromium/net/Http2TestHandler.java View 1 chunk +199 lines, -0 lines 0 comments Download
A components/cronet/android/test/src/org/chromium/net/Http2TestServer.java View 1 chunk +176 lines, -0 lines 0 comments Download
A third_party/netty/README.chromium View 1 chunk +9 lines, -0 lines 0 comments Download
A third_party/netty/netty.gyp View 1 chunk +34 lines, -0 lines 0 comments Download

Dependent Patchsets:

Issue 1412243012 Patch 500001

Messages

Total messages: 6 (3 generated)
mef
FYI. This CL implements Http2TestServer and Http2TestHandler based on prebuilt Netty binaries that run in ...
5 years ago (2015-12-15 16:28:50 UTC) #4
pauljensen
Why are there no prebuilt binaries in this CL?
5 years ago (2015-12-15 17:03:36 UTC) #5
mef
5 years ago (2015-12-15 17:08:15 UTC) #6 
On 2015/12/15 17:03:36, pauljensen wrote:
> Why are there no prebuilt binaries in this CL?

Because they are fairly big (circa 6mb) and possibly use internal boringssl.

Powered by Google App Engine
This is Rietveld 408576698