Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 1529623003: Disable support for swapped out RenderFrame(Host) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Make the navigation entry DCHECK conditional. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/common/site_isolation_policy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index 4755716effca5085531146e6c63cf52996454939..a093dff219dc24bb4d7158472428d49dbdf483b7 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -3959,10 +3959,13 @@ void WebContentsImpl::UpdateState(RenderViewHost* rvh,
if (!entry)
return;
- NavigationEntryImpl* new_entry = controller_.GetEntryWithUniqueID(
- static_cast<RenderFrameHostImpl*>(rvhi->GetMainFrame())->nav_entry_id());
+ if (rvhi->GetMainFrame()) {
+ NavigationEntryImpl* new_entry = controller_.GetEntryWithUniqueID(
Charlie Reis 2015/12/16 17:52:25 Please add a comment that this is a sanity check t
+ static_cast<RenderFrameHostImpl*>(rvhi->GetMainFrame())
+ ->nav_entry_id());
- DCHECK_EQ(entry, new_entry);
+ DCHECK_EQ(entry, new_entry);
+ }
if (page_state == entry->GetPageState())
return; // Nothing to update.
« no previous file with comments | « no previous file | content/common/site_isolation_policy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698