Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1529623003:
Disable support for swapped out RenderFrame(Host) (Closed)
|
Created:
5 years ago by nasko Modified:
5 years ago Reviewers:
Charlie Reis CC:
chromium-reviews, darin-cc_chromium.org, jam, site-isolation-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDisable support for swapped out RenderFrame(Host)
Various bugs have been fixed since the last attempt so this is another
try at disabling swapped out RenderFrame(Host) usage.
BUG=357747
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
Committed: https://crrev.com/a590fefdefb1002bdeb4673fab4e88017cc3b211
Cr-Commit-Position: refs/heads/master@{#365711}
Patch Set 1 #Patch Set 2 : Make the navigation entry DCHECK conditional. #
Total comments: 1
Patch Set 3 : Rebase on ToT to pick up DCHECK change. #
Messages
Total messages: 20 (9 generated)
Description was changed from ========== Disable support for swapped out RenderFrame(Host) Various bugs have been fixed since the last attempt so this is another try at disabling swapped out RenderFrame(Host) usage. BUG=357747 ========== to ========== Disable support for swapped out RenderFrame(Host) Various bugs have been fixed since the last attempt so this is another try at disabling swapped out RenderFrame(Host) usage. BUG=357747 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation ==========
Hey Charlie, Can you stamp the next iteration of trying to kill swapped out? Thanks in advance! Nasko
The CQ bit was checked by nasko@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1529623003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1529623003/1
nasko@chromium.org changed reviewers: + creis@chromium.org
Actually adding Charlie.
LGTM! We should be closer now. Let's see what happens.
The CQ bit was unchecked by nasko@chromium.org
The CQ bit was checked by nasko@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1529623003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1529623003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...) mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
I ran something similar yesterday on https://codereview.chromium.org/1525103002/, and it failed linux_android_rel_ng. I'm shocked that the build logs are gone already, but it failed some tests, including: RenderFrameHostManagerTest.RendererDebugURLsDontSwap All the Android bots seem to be missing try jobs in this patch, so we should be sure to run some before landing this. https://codereview.chromium.org/1529623003/diff/20001/content/browser/web_con... File content/browser/web_contents/web_contents_impl.cc (right): https://codereview.chromium.org/1529623003/diff/20001/content/browser/web_con... content/browser/web_contents/web_contents_impl.cc:3963: NavigationEntryImpl* new_entry = controller_.GetEntryWithUniqueID( Please add a comment that this is a sanity check to ensure nav_entry_id and page_id point to the same entry.
Huh, the Android bots are happy on my CL again. Ok, this LGTM if the bots are happy.
The CQ bit was checked by nasko@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1529623003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1529623003/40001
Message was sent while issue was closed.
Description was changed from ========== Disable support for swapped out RenderFrame(Host) Various bugs have been fixed since the last attempt so this is another try at disabling swapped out RenderFrame(Host) usage. BUG=357747 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation ========== to ========== Disable support for swapped out RenderFrame(Host) Various bugs have been fixed since the last attempt so this is another try at disabling swapped out RenderFrame(Host) usage. BUG=357747 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Disable support for swapped out RenderFrame(Host) Various bugs have been fixed since the last attempt so this is another try at disabling swapped out RenderFrame(Host) usage. BUG=357747 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation ========== to ========== Disable support for swapped out RenderFrame(Host) Various bugs have been fixed since the last attempt so this is another try at disabling swapped out RenderFrame(Host) usage. BUG=357747 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/a590fefdefb1002bdeb4673fab4e88017cc3b211 Cr-Commit-Position: refs/heads/master@{#365711} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/a590fefdefb1002bdeb4673fab4e88017cc3b211 Cr-Commit-Position: refs/heads/master@{#365711} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
