Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1529613002: Add TimelineBeginEndScope helper class (Closed)

Created:
5 years ago by Cutch
Modified:
5 years ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add TimelineBeginEndScope helper class - Refactor TimelineDurationScope into TimelineEventScope. - Reintroduce TimelineDurationScope based on TimelineEventScope. - Add TimelineBeginEndScope. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/cc9b72411d8e7e0c5d66055339ef0440e7c50107

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+177 lines, -48 lines) Patch
M runtime/vm/timeline.h View 2 chunks +63 lines, -11 lines 0 comments Download
M runtime/vm/timeline.cc View 9 chunks +114 lines, -37 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
Cutch
5 years ago (2015-12-14 19:47:29 UTC) #4
rmacnak
lgtm
5 years ago (2015-12-14 20:37:23 UTC) #5
Cutch
5 years ago (2015-12-14 20:45:43 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cc9b72411d8e7e0c5d66055339ef0440e7c50107 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698