Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Issue 1529603002: Revert of SkTime updates (Closed)

Created:
5 years ago by mtklein
Modified:
5 years ago
Reviewers:
herb_g, mtklein_C
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of SkTime updates (patchset #2 id:20001 of https://codereview.chromium.org/1521293002/ ) Reason for revert: linux Canary builder has no std::steady_clock. Weird... Original issue's description: > SkTime updates > > 1) Use steady_clock instead of high_resolution_clock. If we don't have a > guarantee of monotonicity, it's pretty much useless for timing things. > > 2) Implement Mac/iOS with <chrono> too. This was waiting on C++11 library support. > > Both high_resolution_clock and steady_clock are (still) busted on MSVC 2013, > so no change there. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/6a20871e5aeaa7e61f3348694bf436af16f824b9 TBR=herb@google.com,mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/4e4155df100b77d11bd14591c7716743369fde9b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -4 lines) Patch
M src/core/SkTime.cpp View 1 chunk +15 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
mtklein
Created Revert of SkTime updates
5 years ago (2015-12-14 18:54:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1529603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1529603002/1
5 years ago (2015-12-14 18:54:14 UTC) #2
commit-bot: I haz the power
5 years ago (2015-12-14 18:54:28 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/4e4155df100b77d11bd14591c7716743369fde9b

Powered by Google App Engine
This is Rietveld 408576698