Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 15296005: Remove obsolete code in input method handling (Closed)

Created:
7 years, 7 months ago by Seigo Nonaka
Modified:
7 years, 7 months ago
Reviewers:
sky, yukawa, Yohei Yukawa
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove obsolete code in input method handling I checked this code and comment is obsolete and working correctly on password field. We should not call IMM32 API in the case of pure TSF, otherwise seems state of input method become inconsistent state. BUG=239690 TEST=Manually done on Win 8 both TSF and IMM32 implementation. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201263

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M ui/views/win/hwnd_message_handler.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Seigo Nonaka
Hi Yukawa, I'd like you to review this file. Thank you.
7 years, 7 months ago (2013-05-17 12:53:36 UTC) #1
Yohei Yukawa
lgtm
7 years, 7 months ago (2013-05-20 02:56:36 UTC) #2
Seigo Nonaka
Yukawa, Thank you for your review! Adding sky@ as the owner of ui/ Hi Scott, ...
7 years, 7 months ago (2013-05-20 03:18:28 UTC) #3
Seigo Nonaka
Yukawa, Thank you for your review! Adding sky@ as the owner of ui/ Hi Scott, ...
7 years, 7 months ago (2013-05-20 16:54:23 UTC) #4
sky
LGTM
7 years, 7 months ago (2013-05-20 19:53:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/15296005/1
7 years, 7 months ago (2013-05-20 23:56:20 UTC) #6
commit-bot: I haz the power
7 years, 7 months ago (2013-05-21 08:37:11 UTC) #7
Message was sent while issue was closed.
Change committed as 201263

Powered by Google App Engine
This is Rietveld 408576698