core/src/fpdfapi/fpdf_font/fpdf_font.cpp - Issue 1529553003: Merge to XFA: Get rid of most instance of 'foo != NULL'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_font/fpdf_font.cpp

Issue 1529553003: Merge to XFA: Get rid of most instance of 'foo != NULL' (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fpdfapi/fpdf_font/fpdf_font.cpp

diff --git a/core/src/fpdfapi/fpdf_font/fpdf_font.cpp b/core/src/fpdfapi/fpdf_font/fpdf_font.cpp

index b515d90a7fafd7363e9cf1cd5122ea4289f68971..4a71382da4c4d39af1b232e35782ff7c6a6c6c06 100644

--- a/core/src/fpdfapi/fpdf_font/fpdf_font.cpp

+++ b/core/src/fpdfapi/fpdf_font/fpdf_font.cpp

@@ -1519,7 +1519,7 @@ void CPDF_TrueTypeFont::LoadGlyphMap() {

}

if ((m_GlyphIndex[charcode] == 0 || m_GlyphIndex[charcode] == 0xffff) &&

- name != NULL) {

+ name) {

if (name[0] == '.' && FXSYS_strcmp(name, ".notdef") == 0) {

m_GlyphIndex[charcode] = FXFT_Get_Char_Index(m_Font.GetFace(), 32);

} else {