Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 152953004: Improve computation of effects for load elimination. (Closed)

Created:
6 years, 10 months ago by Benedikt Meurer
Modified:
6 years, 10 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Visibility:
Public.

Description

Improve computation of effects for load elimination. R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19322

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix #

Patch Set 3 : Add comment. #

Patch Set 4 : REBASE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -32 lines) Patch
M src/hydrogen-load-elimination.cc View 1 2 4 chunks +12 lines, -32 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Benedikt Meurer
Hey Igor, This is a simple code cleanup. PTAL -- Benedikt
6 years, 10 months ago (2014-02-11 12:12:09 UTC) #1
Benedikt Meurer
Hey Igor, This is a simple code cleanup. PTAL -- Benedikt
6 years, 10 months ago (2014-02-11 12:12:10 UTC) #2
Igor Sheludko
https://codereview.chromium.org/152953004/diff/1/src/hydrogen-load-elimination.cc File src/hydrogen-load-elimination.cc (right): https://codereview.chromium.org/152953004/diff/1/src/hydrogen-load-elimination.cc#newcode469 src/hydrogen-load-elimination.cc:469: flags_ = that->flags_; Probably you want to union GVN ...
6 years, 10 months ago (2014-02-11 13:01:56 UTC) #3
Benedikt Meurer
https://codereview.chromium.org/152953004/diff/1/src/hydrogen-load-elimination.cc File src/hydrogen-load-elimination.cc (right): https://codereview.chromium.org/152953004/diff/1/src/hydrogen-load-elimination.cc#newcode469 src/hydrogen-load-elimination.cc:469: flags_ = that->flags_; Indeed, thanks for spotting.
6 years, 10 months ago (2014-02-12 06:22:42 UTC) #4
Igor Sheludko
lgtm with nit: Probably it is worth preserving comment about OsrEntry: // Kill everything. Loads ...
6 years, 10 months ago (2014-02-12 09:51:53 UTC) #5
Benedikt Meurer
6 years, 10 months ago (2014-02-12 12:34:19 UTC) #6
Message was sent while issue was closed. 
Committed patchset #4 manually as r19322 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698