Continue bitmap fetching for notifications.

chrome/browser/notifications/sync_notifier/notification_bitmap_fetcher_browsertest.cc

Index: chrome/browser/notifications/sync_notifier/notification_bitmap_fetcher_browsertest.cc
diff --git a/chrome/browser/notifications/sync_notifier/notification_bitmap_fetcher_browsertest.cc b/chrome/browser/notifications/sync_notifier/notification_bitmap_fetcher_browsertest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..15c5f829ea9e059cd20f774b65c0f6b7e128ece6
--- /dev/null
+++ b/chrome/browser/notifications/sync_notifier/notification_bitmap_fetcher_browsertest.cc
@@ -0,0 +1,179 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/notifications/sync_notifier/notification_bitmap_fetcher.h"
+
+#include "base/compiler_specific.h"
+#include "chrome/test/base/in_process_browser_test.h"
+#include "content/public/browser/browser_thread.h"
+#include "content/public/test/test_utils.h"
+#include "net/url_request/test_url_fetcher_factory.h"
+#include "net/url_request/url_fetcher.h"
+#include "net/url_request/url_request_status.h"
+#include "testing/gtest/include/gtest/gtest.h"
+#include "third_party/skia/include/core/SKBitmap.h"
+#include "ui/gfx/codec/png_codec.h"
+#include "ui/gfx/size.h"
+#include "ui/gfx/skia_util.h"
+
+namespace {
+// FF0000FF is 100% alpha and max green.(A, R, B, G)
+uint32 kMaxGreen = 0xFF0000FF;
+const bool kAsyncCall = true;
+const bool kSyncCall = false;
+const bool kSuccess = true;
+const bool kFailure = false;
+}  // namespace
+
+namespace notifier {
+
+// Class to catch events from the NotificationBitmapFetcher for testing.
+class NotificationBitmapFetcherTestDelegate
+    : public NotificationBitmapFetcherDelegate {
+ public:
+  explicit NotificationBitmapFetcherTestDelegate(bool async)
+      : success_(false), async_(async) {}
+
+  virtual ~NotificationBitmapFetcherTestDelegate() {}
+
+  // Method inherited from NotificationBitmapFetcherDelegate
+  void OnFetchComplete(const SkBitmap* bitmap) OVERRIDE {
+    if (NULL != bitmap) {
+      success_ = true;
+      bitmap->deepCopyTo(&bitmap_, bitmap->getConfig());
+    }
+    // For async calls, we need to quit the message loop so the test can
+    // continue.
+    if (async_) {
+      MessageLoop::current()->Quit();
+    }
+  }
+
+  bool success() const { return success_; }
+  const SkBitmap& bitmap() const { return bitmap_; }
+
+ private:
+  bool success_;
+  bool async_;
+  SkBitmap bitmap_;
+
+  DISALLOW_COPY_AND_ASSIGN(NotificationBitmapFetcherTestDelegate);
+};
+
+typedef InProcessBrowserTest NotificationBitmapFetcherBrowserTest;
+
+// WARNING:  These tests work with --single_process, but not
+// --single-process.  The reason is that the sandbox does not get created
+// for us by the test process if --single-process is used.
+
+IN_PROC_BROWSER_TEST_F(NotificationBitmapFetcherBrowserTest,
+                       StartTest) {
+  GURL url("http://localhost");
+
+  // Put some realistic looking bitmap data into the url_fetcher.
+  SkBitmap image;
+
+  // Put a real bitmap into "image".  2x2 bitmap of green 32 bit pixels.
+  image.setConfig(SkBitmap::kARGB_8888_Config, 2, 2);
+  image.allocPixels();
+  SkColor c = kMaxGreen;
+  image.eraseColor(c);
+
+  // Encode the bits as a PNG.
+  std::vector<unsigned char> compressed;
+  ASSERT_TRUE(gfx::PNGCodec::EncodeBGRASkBitmap(image, true, &compressed));
+
+  // Copy the bits into the string, and put them into the FakeURLFetcher.
+  std::string image_string(compressed.begin(), compressed.end());
+
+  // Set up a delegate to wait for the callback.
+  NotificationBitmapFetcherTestDelegate delegate(kAsyncCall);
+
+  NotificationBitmapFetcher fetcher(url, &delegate);
+
+  scoped_ptr<net::URLFetcher> url_fetcher(new net::FakeURLFetcher(
+      url, &fetcher, image_string, kSuccess));
+  fetcher.SetURLFetcherForTest(url_fetcher.Pass());
+
+  // We expect that the image decoder will get called and return
+  // an image in a callback to OnImageDecoded().
+  fetcher.Start();
+
+  // Blocks until test delegate is notified via a callback.
+  content::RunMessageLoop();
+
+  ASSERT_TRUE(delegate.success());
+
+  // Make sure we get back the bitmap we expect.
+  const SkBitmap& found_image = delegate.bitmap();
+  EXPECT_TRUE(gfx::BitmapsAreEqual(image, found_image));
+}
+
+
+IN_PROC_BROWSER_TEST_F(NotificationBitmapFetcherBrowserTest,
+                       OnImageDecodedTest) {
+  GURL url("http://localhost");
+  SkBitmap image;
+
+  // Put a real bitmap into "image".  2x2 bitmap of green 16 bit pixels.
+  image.setConfig(SkBitmap::kARGB_8888_Config, 2, 2);
+  image.allocPixels();
+  SkColor c = kMaxGreen;
+  image.eraseColor(c);
+
+  NotificationBitmapFetcherTestDelegate delegate(kSyncCall);
+
+  NotificationBitmapFetcher fetcher(url, &delegate);
+
+  scoped_ptr<net::URLFetcher> url_fetcher(
+      new net::TestURLFetcher(1, url, &fetcher));
+  fetcher.SetURLFetcherForTest(url_fetcher.Pass());

[dcheng, 2013/05/31 02:34:52]

If this test remains, note that url_fetcher is completely unused.

[Pete Williamson, 2013/05/31 16:42:20]

Good point, removed.

+
+  fetcher.OnImageDecoded(NULL, image);
+
+  // Ensure image is marked as succeeded.
+  EXPECT_TRUE(delegate.success());
+
+  // Test that the image is stored and ready. Pixel [0,0] should be green.
+  EXPECT_TRUE(gfx::BitmapsAreEqual(image, delegate.bitmap()));
+
+}
+
+IN_PROC_BROWSER_TEST_F(NotificationBitmapFetcherBrowserTest,
+                       OnURLFetchFailureTest) {
+  GURL url("http://localhost");
+
+  // We intentionally put no data into the bitmap to simulate a failure.
+
+  // Set up a delegate to wait for the callback.
+  NotificationBitmapFetcherTestDelegate delegate(kAsyncCall);
+
+  // The fetcher controls the lifetime of url_fetcher, but we keep a
+  // pointer to it with stub_url_fetcher.
+  NotificationBitmapFetcher fetcher(url, &delegate);
+
+  scoped_ptr<net::URLFetcher> url_fetcher(new net::FakeURLFetcher(
+      url, &fetcher, std::string(), kFailure));
+  fetcher.SetURLFetcherForTest(url_fetcher.Pass());
+
+  fetcher.Start();
+

[dcheng, 2013/05/31 02:34:52]

I think this test needs to run the message loop to work properly.

[Pete Williamson, 2013/05/31 16:42:20]

Surprisingly, it passed without the message loop, but I added the message loop
anyway so it will be theoretically correct, and it still passes, so I'll submit
it with the message loop.

[dcheng, 2013/05/31 17:36:04]

success() defaults to false, so that's why it passed, even though no code was
actually running.

+  EXPECT_FALSE(delegate.success());
+}
+
+IN_PROC_BROWSER_TEST_F(NotificationBitmapFetcherBrowserTest,
+                       HandleImageFailedTest) {
+  GURL url("http://localhost");
+  NotificationBitmapFetcherTestDelegate delegate(kAsyncCall);
+  NotificationBitmapFetcher fetcher(url, &delegate);
+  scoped_ptr<net::URLFetcher> url_fetcher(new net::FakeURLFetcher(
+      url, &fetcher, std::string("Not a real bitmap"), kSuccess));
+  fetcher.SetURLFetcherForTest(url_fetcher.Pass());
+
+  fetcher.Start();
+

[dcheng, 2013/05/31 02:34:52]

Ditto.

[Pete Williamson, 2013/05/31 16:42:20]

Same response.

+  EXPECT_FALSE(delegate.success());
+}
+
+}  // namespace notifier