Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Unified Diff: chrome/browser/notifications/sync_notifier/notification_bitmap_fetcher.h

Issue 15295018: Continue bitmap fetching for notifications. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Synced Notification Bitmap Fetching - refactor unit tests into browser test Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/sync_notifier/notification_bitmap_fetcher.h
diff --git a/chrome/browser/notifications/sync_notifier/notification_bitmap_fetcher.h b/chrome/browser/notifications/sync_notifier/notification_bitmap_fetcher.h
new file mode 100644
index 0000000000000000000000000000000000000000..1193c839cba59e7db91a99fbdb2818aa34cb34e2
--- /dev/null
+++ b/chrome/browser/notifications/sync_notifier/notification_bitmap_fetcher.h
@@ -0,0 +1,87 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_NOTIFICATIONS_SYNC_NOTIFIER_NOTIFICATION_BITMAP_FETCHER_H_
+#define CHROME_BROWSER_NOTIFICATIONS_SYNC_NOTIFIER_NOTIFICATION_BITMAP_FETCHER_H_
+
+#include "base/gtest_prod_util.h"
+#include "base/memory/scoped_ptr.h"
+#include "base/message_loop/message_loop_proxy.h"
dcheng 2013/05/29 20:40:29 This isn't used in the header.
Pete Williamson 2013/05/30 00:13:18 Done.
+#include "chrome/browser/image_decoder.h"
+#include "googleurl/src/gurl.h"
+#include "net/url_request/url_fetcher_delegate.h"
+#include "third_party/skia/include/core/SKBitmap.h"
+
+namespace net {
+class URLFetcher;
+} // namespace net
+
+class NotificationBitmapFetcherTest;
+class NotificationBitmapFetcherBrowserTest;
dcheng 2013/05/29 20:40:29 Not needed.
Pete Williamson 2013/05/30 00:13:18 Done.
+
+namespace notifier {
+
+// A delegate interface for users of NotificationBitmapFetcher.
+class NotificationBitmapFetcherDelegate {
+ public:
+ // This will be called when the bitmap has been fetched, successfully or not.
+ virtual void OnFetchComplete(GURL url, const SkBitmap* bitmap) = 0;
+
+ protected:
+ virtual ~NotificationBitmapFetcherDelegate() {}
+};
+
+class NotificationBitmapFetcher
+ : public net::URLFetcherDelegate,
+ public ImageDecoder::Delegate,
+ public base::RefCountedThreadSafe<NotificationBitmapFetcher> {
+ public:
+ explicit NotificationBitmapFetcher(
+ const GURL& url,
+ NotificationBitmapFetcherDelegate* delegate);
+ ~NotificationBitmapFetcher();
+
+ // Start fetching the URL with the fetcher. The operation will be continued
+ // in the OnURLFetchComplete callback.
+ void StartImageFetch();
+
+ // Methods inherited from URLFetcherDelegate
+
+ // This will be called when the URL has been fetched, successfully or not.
+ // Use accessor methods on |source| to get the results.
+ virtual void OnURLFetchComplete(const net::URLFetcher* source) OVERRIDE;
+
+ // This will be called when some part of the response is read. |current|
+ // denotes the number of bytes received up to the call, and |total| is the
+ // expected total size of the response (or -1 if not determined).
+ virtual void OnURLFetchDownloadProgress(const net::URLFetcher* source,
+ int64 current, int64 total) OVERRIDE;
+
+ // Methods inherited from ImageDecoder::Delegate
+
+ // Called when image is decoded. |decoder| is used to identify the image in
+ // case of decoding several images simultaneously. This will not be called
+ // on the UI thread.
+ virtual void OnImageDecoded(const ImageDecoder* decoder,
+ const SkBitmap& decoded_image) OVERRIDE;
+
+ // Called when decoding image failed.
+ virtual void OnDecodeImageFailed(const ImageDecoder* decoder) OVERRIDE;
+
+ // Used to pass in a fetcher for dependency injection in tests.
+ void SetURLFetcherForTest(scoped_ptr<net::URLFetcher>& url_fetcher);
+
+ private:
+ scoped_ptr<net::URLFetcher> url_fetcher_;
+ scoped_refptr<ImageDecoder> image_decoder_;
+ const GURL url_;
+ scoped_ptr<SkBitmap> bitmap_;
+ NotificationBitmapFetcherDelegate* const delegate_;
+
+ DISALLOW_COPY_AND_ASSIGN(NotificationBitmapFetcher);
+};
+
+} // namespace notifier
+
+#endif // CHROME_BROWSER_NOTIFICATIONS_SYNC_NOTIFIER_NOTIFICATION_BITMAP_FETCHER_H_

Powered by Google App Engine
This is Rietveld 408576698