Continue bitmap fetching for notifications.

chrome/browser/notifications/sync_notifier/notification_bitmap_fetcher.h

Index: chrome/browser/notifications/sync_notifier/notification_bitmap_fetcher.h
diff --git a/chrome/browser/notifications/sync_notifier/notification_bitmap_fetcher.h b/chrome/browser/notifications/sync_notifier/notification_bitmap_fetcher.h
new file mode 100644
index 0000000000000000000000000000000000000000..4206e74f4e5248224be994eebfe26984db929ace
--- /dev/null
+++ b/chrome/browser/notifications/sync_notifier/notification_bitmap_fetcher.h
@@ -0,0 +1,107 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_NOTIFICATIONS_SYNC_NOTIFIER_NOTIFICATION_BITMAP_FETCHER_H_
+#define CHROME_BROWSER_NOTIFICATIONS_SYNC_NOTIFIER_NOTIFICATION_BITMAP_FETCHER_H_
+
+#include "base/gtest_prod_util.h"
+#include "base/memory/scoped_ptr.h"
+#include "base/message_loop/message_loop_proxy.h"
+#include "chrome/browser/image_decoder.h"
+#include "googleurl/src/gurl.h"
+#include "net/url_request/url_fetcher_delegate.h"
+#include "third_party/skia/include/core/SKBitmap.h"
+
+namespace net {
+class URLFetcher;
+}  // namespace net
+
+class NotificationBitmapFetcherTest;
+class NotificationBitmapFetcherBrowserTest;
+
+namespace notifier {
+
+class NotificationBitmapFetcher
+    : public net::URLFetcherDelegate,
+      public ImageDecoder::Delegate,
+      public base::RefCountedThreadSafe<NotificationBitmapFetcher> {
+ public:
+  explicit NotificationBitmapFetcher(GURL& url);

[dcheng, 2013/05/23 19:32:25]

Style: Chromium does not allow mutable references.

[Pete Williamson, 2013/05/24 22:18:06]

Done.

+  ~NotificationBitmapFetcher();
+
+  bool image_ready();

[dcheng, 2013/05/23 19:32:25]

Style: Simple getters should be inlined into the header (and should be marked
const).

[Pete Williamson, 2013/05/24 22:18:06]

removed.

+
+  bool image_failed();
+
+  // Returns an unowned pointer to the fetched and decoded bitmap.
+  SkBitmap* bitmap();

[dcheng, 2013/05/23 19:32:25]

Prefer returning const pointers/references. Note that by using a delegate
pattern, none of these getters will be needed though.

[Pete Williamson, 2013/05/24 22:18:06]

Removed.

+
+  // Start fetching the URL with the fetcher.  The operation will be continued
+  // in the OnURLFetchComplete callback.
+  void StartImageFetch();
+
+  // Copy the output bitmap. This takes ownership of the bitmap.  It is called
+  // on the UI thread. This also notifies observers.
+  void HandleImageDecoded(scoped_ptr<SkBitmap> bitmap);
+
+  // If a bitmap image decode fails, notify observers of the failure.
+  void HandleImageFailed();
+
+  // Methods inherited from URLFetcherDelegate
+
+  // This will be called when the URL has been fetched, successfully or not.
+  // Use accessor methods on |source| to get the results.
+  virtual void OnURLFetchComplete(const net::URLFetcher* source) OVERRIDE;
+
+  // This will be called when some part of the response is read. |current|
+  // denotes the number of bytes received up to the call, and |total| is the
+  // expected total size of the response (or -1 if not determined).
+  virtual void OnURLFetchDownloadProgress(const net::URLFetcher* source,
+                                          int64 current, int64 total) OVERRIDE;
+
+  // Methods inherited from ImageDecoder::Delegate
+
+  // Called when image is decoded. |decoder| is used to identify the image in
+  // case of decoding several images simultaneously.  This will not be called
+  // on the UI thread.
+  virtual void OnImageDecoded(const ImageDecoder* decoder,
+                              const SkBitmap& decoded_image) OVERRIDE;
+
+  // Called when decoding image failed.
+  virtual void OnDecodeImageFailed(const ImageDecoder* decoder) OVERRIDE;
+
+ private:
+  scoped_ptr<net::URLFetcher> url_fetcher_;
+  scoped_refptr<ImageDecoder> image_decoder_;
+  // |image_ready_| will be set to true once the image is fetched and decoded.
+  bool image_ready_;
+  // |image_failed_| will be set to true if we cannot fetch or decode the image.
+  bool image_failed_;
+  GURL url_;
+  scoped_ptr<SkBitmap> bitmap_;
+  int64 progress_current_;
+  int64 progress_total_;
+
+  // Used to pass in a fetcher for dependency injection in tests.
+  void SetURLFetcherForTest(scoped_ptr<net::URLFetcher>& url_fetcher);
+
+  FRIEND_TEST_ALL_PREFIXES(NotificationBitmapFetcherTest, ImageReadyTest);
+  FRIEND_TEST_ALL_PREFIXES(NotificationBitmapFetcherTest, StartFetchTest);
+  FRIEND_TEST_ALL_PREFIXES(NotificationBitmapFetcherTest,
+                           HandleImageDecodedTest);
+  FRIEND_TEST_ALL_PREFIXES(NotificationBitmapFetcherTest,
+                           HandleImageFailedTest);
+  FRIEND_TEST_ALL_PREFIXES(NotificationBitmapFetcherBrowserTest,
+                           OnURLFetchCompleteTest);
+  FRIEND_TEST_ALL_PREFIXES(NotificationBitmapFetcherBrowserTest,
+                           OnDecodeImageFailedTest);
+  FRIEND_TEST_ALL_PREFIXES(NotificationBitmapFetcherBrowserTest,
+                           OnURLFetchFailureTest);
+
+  DISALLOW_COPY_AND_ASSIGN(NotificationBitmapFetcher);
+};
+
+}  // namespace notifier
+
+#endif  // CHROME_BROWSER_NOTIFICATIONS_SYNC_NOTIFIER_NOTIFICATION_BITMAP_FETCHER_H_