Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1208)

Issue 1529423002: Dart: Fix conversion of identifiers to lowerCamelCase. (Closed)

Created:
5 years ago by zra
Modified:
5 years ago
Reviewers:
Cutch
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Dart: Fix conversion of identifiers to lowerCamelCase. Before we'd get e.g. IPV4 -> ipV4 because '4' was treated as lower-case. After this change we'll get IPV4 -> ipv4 because digits are instead treated as upper-case for the purposes of terminating a string of lower-case characters. R=johnmccutchan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/00cecc86d0e5661aff8a22500911bb3cd0882532

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : Comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+339 lines, -192 lines) Patch
M examples/dart/netcat/lib/main.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/embedder/io/internet_address_patch.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/dart/embedder/io/mojo_patch.dart View 6 chunks +8 lines, -8 lines 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/regression_tests/regression_tests.mojom.dart View 1 2 1 chunk +113 lines, -0 lines 0 comments Download
M mojo/dart/packages/mojo/lib/mojo/bindings/types/mojom_types.mojom.dart View 4 chunks +48 lines, -48 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/files/ioctl_terminal.mojom.dart View 3 chunks +16 lines, -16 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/gpu.mojom.dart View 6 chunks +14 lines, -14 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/input_event_constants.mojom.dart View 5 chunks +6 lines, -6 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/input_key_codes.mojom.dart View 15 chunks +72 lines, -72 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/net_address.mojom.dart View 3 chunks +12 lines, -12 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/surfaces.mojom.dart View 5 chunks +6 lines, -6 lines 0 comments Download
M mojo/dart/test/bindings_generation_test.dart View 1 2 3 chunks +24 lines, -4 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/regression_tests.mojom View 1 2 1 chunk +14 lines, -0 lines 0 comments Download
M mojo/public/tools/bindings/generators/mojom_dart_generator.py View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
zra
5 years ago (2015-12-17 18:14:07 UTC) #4
Cutch
lgtm
5 years ago (2015-12-17 18:36:46 UTC) #5
zra
5 years ago (2015-12-17 19:17:40 UTC) #7
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
00cecc86d0e5661aff8a22500911bb3cd0882532 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698