StorageMonitor: Make StorageInfo a real class.

chrome/browser/storage_monitor/storage_monitor_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/message_loop.h"
 #include "base/synchronization/waitable_event.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/storage_monitor/mock_removable_storage_observer.h"
 #include "chrome/browser/storage_monitor/storage_monitor.h"
 #include "chrome/browser/storage_monitor/test_storage_monitor.h"
@@ skipping 23 matching lines @@
   MockRemovableStorageObserver observer2;
   test::TestStorageMonitor monitor;
   monitor.AddObserver(&observer1);
   monitor.AddObserver(&observer2);
 
   StorageInfo info(kDeviceId1, kDeviceName, FILE_PATH_LITERAL("path"),
                    string16(), string16(), string16(), 0);
   monitor.receiver()->ProcessAttach(info);
   message_loop.RunUntilIdle();
 
-  EXPECT_EQ(kDeviceId1, observer1.last_attached().device_id);
-  EXPECT_EQ(kDeviceName, observer1.last_attached().name);
-  EXPECT_EQ(FILE_PATH_LITERAL("path"), observer1.last_attached().location);
-  EXPECT_EQ(kDeviceId1, observer2.last_attached().device_id);
-  EXPECT_EQ(kDeviceName, observer2.last_attached().name);
-  EXPECT_EQ(FILE_PATH_LITERAL("path"), observer2.last_attached().location);
+  EXPECT_EQ(kDeviceId1, observer1.last_attached().device_id());
+  EXPECT_EQ(kDeviceName, observer1.last_attached().name());
+  EXPECT_EQ(FILE_PATH_LITERAL("path"), observer1.last_attached().location());
+  EXPECT_EQ(kDeviceId1, observer2.last_attached().device_id());
+  EXPECT_EQ(kDeviceName, observer2.last_attached().name());
+  EXPECT_EQ(FILE_PATH_LITERAL("path"), observer2.last_attached().location());
   EXPECT_EQ(1, observer1.attach_calls());
   EXPECT_EQ(0, observer1.detach_calls());
 
   monitor.receiver()->ProcessDetach(kDeviceId1);
   monitor.receiver()->ProcessDetach(kDeviceId2);
   message_loop.RunUntilIdle();
 
-  EXPECT_EQ(kDeviceId1, observer1.last_detached().device_id);
-  EXPECT_EQ(kDeviceName, observer1.last_detached().name);
-  EXPECT_EQ(FILE_PATH_LITERAL("path"), observer1.last_detached().location);
-  EXPECT_EQ(kDeviceId1, observer2.last_detached().device_id);
-  EXPECT_EQ(kDeviceName, observer2.last_detached().name);
-  EXPECT_EQ(FILE_PATH_LITERAL("path"), observer2.last_detached().location);
+  EXPECT_EQ(kDeviceId1, observer1.last_detached().device_id());
+  EXPECT_EQ(kDeviceName, observer1.last_detached().name());
+  EXPECT_EQ(FILE_PATH_LITERAL("path"), observer1.last_detached().location());
+  EXPECT_EQ(kDeviceId1, observer2.last_detached().device_id());
+  EXPECT_EQ(kDeviceName, observer2.last_detached().name());
+  EXPECT_EQ(FILE_PATH_LITERAL("path"), observer2.last_detached().location());
 
   EXPECT_EQ(1, observer1.attach_calls());
   EXPECT_EQ(1, observer2.attach_calls());
 
   // The kDeviceId2 won't be notified since it was never attached.
   EXPECT_EQ(1, observer1.detach_calls());
   EXPECT_EQ(1, observer2.detach_calls());
 
   monitor.RemoveObserver(&observer1);
   monitor.RemoveObserver(&observer2);
@@ skipping 11 matching lines @@
   test::TestStorageMonitor monitor;
   const std::string kDeviceId1 = "42";
   const string16 kDeviceName1 = ASCIIToUTF16("test");
   const base::FilePath kDevicePath1(FILE_PATH_LITERAL("/testfoo"));
   StorageInfo info1(kDeviceId1, kDeviceName1, kDevicePath1.value(),
                     string16(), string16(), string16(), 0);
   monitor.receiver()->ProcessAttach(info1);
   message_loop.RunUntilIdle();
   std::vector<StorageInfo> devices = monitor.GetAttachedStorage();
   ASSERT_EQ(1U, devices.size());
-  EXPECT_EQ(kDeviceId1, devices[0].device_id);
-  EXPECT_EQ(kDeviceName1, devices[0].name);
-  EXPECT_EQ(kDevicePath1.value(), devices[0].location);
+  EXPECT_EQ(kDeviceId1, devices[0].device_id());
+  EXPECT_EQ(kDeviceName1, devices[0].name());
+  EXPECT_EQ(kDevicePath1.value(), devices[0].location());
 
   const std::string kDeviceId2 = "44";
   const string16 kDeviceName2 = ASCIIToUTF16("test2");
   const base::FilePath kDevicePath2(FILE_PATH_LITERAL("/testbar"));
   StorageInfo info2(kDeviceId2, kDeviceName2, kDevicePath2.value(),
                     string16(), string16(), string16(), 0);
   monitor.receiver()->ProcessAttach(info2);
   message_loop.RunUntilIdle();
   devices = monitor.GetAttachedStorage();
   ASSERT_EQ(2U, devices.size());
-  EXPECT_EQ(kDeviceId1, devices[0].device_id);
-  EXPECT_EQ(kDeviceName1, devices[0].name);
-  EXPECT_EQ(kDevicePath1.value(), devices[0].location);
-  EXPECT_EQ(kDeviceId2, devices[1].device_id);
-  EXPECT_EQ(kDeviceName2, devices[1].name);
-  EXPECT_EQ(kDevicePath2.value(), devices[1].location);
+  EXPECT_EQ(kDeviceId1, devices[0].device_id());
+  EXPECT_EQ(kDeviceName1, devices[0].name());
+  EXPECT_EQ(kDevicePath1.value(), devices[0].location());
+  EXPECT_EQ(kDeviceId2, devices[1].device_id());
+  EXPECT_EQ(kDeviceName2, devices[1].name());
+  EXPECT_EQ(kDevicePath2.value(), devices[1].location());
 
   monitor.receiver()->ProcessDetach(kDeviceId1);
   message_loop.RunUntilIdle();
   devices = monitor.GetAttachedStorage();
   ASSERT_EQ(1U, devices.size());
-  EXPECT_EQ(kDeviceId2, devices[0].device_id);
-  EXPECT_EQ(kDeviceName2, devices[0].name);
-  EXPECT_EQ(kDevicePath2.value(), devices[0].location);
+  EXPECT_EQ(kDeviceId2, devices[0].device_id());
+  EXPECT_EQ(kDeviceName2, devices[0].name());
+  EXPECT_EQ(kDevicePath2.value(), devices[0].location());
 
   monitor.receiver()->ProcessDetach(kDeviceId2);
   message_loop.RunUntilIdle();
   devices = monitor.GetAttachedStorage();
   EXPECT_EQ(0U, devices.size());
 }
 
 }  // namespace chrome