Fix initial erroneous navigation in iframe to not add history entry.

content/renderer/render_view_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_view_impl.h"
 
 #include <algorithm>
 #include <cmath>
 
 #include "base/auto_reset.h"
@@ skipping 3399 matching lines @@
       const content::PasswordForm* old_password_form =
           old_document_state->password_form_data();
       if (old_password_form) {
         document_state->set_password_form_data(
             make_scoped_ptr(new content::PasswordForm(*old_password_form)));
       }
     }
 
     // Make sure redirect tracking state is clear for the new load.
     completed_client_redirect_src_ = Referrer();
-  } else if (frame->parent()->isLoading()) {
+  } else if (frame->parent()->isLoading() ||
+      document_state->navigation_state()->pending_page_id() == -1) {

[Charlie Reis, 2013/05/23 21:53:33]

It's hard to tell whether this fix is correct, since it's not clear how these
conditions relate to each other.

What's the goal here?  Is it that all initial iframe navigations should be
considered auto-subframe?  Is pending_page_id() == -1 a good indicator of that? 
If so, do we still need the isLoading clause?

Maybe a comment about what cases this is trying to address would help.

[nasko, 2013/09/20 21:25:39]

This is now completely rewritten.

     // Take note of AUTO_SUBFRAME loads here, so that we can know how to
     // load an error page.  See didFailProvisionalLoad.
     document_state->navigation_state()->set_transition_type(
         PAGE_TRANSITION_AUTO_SUBFRAME);
   }
 
   FOR_EACH_OBSERVER(
       RenderViewObserver, observers_, DidStartProvisionalLoad(frame));
 
   Send(new ViewHostMsg_DidStartProvisionalLoadForFrame(
@@ skipping 3131 matching lines @@
     WebURL url = icon_urls[i].iconURL();
     if (!url.isEmpty())
       urls.push_back(FaviconURL(url,
                                 ToFaviconType(icon_urls[i].iconType())));
   }
   SendUpdateFaviconURL(urls);
 }
 
 
 }  // namespace content