Fix initial erroneous navigation in iframe to not add history entry.

chrome/browser/errorpage_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/google/google_util.h"
 #include "chrome/browser/net/url_request_mock_util.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_commands.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/test/base/in_process_browser_test.h"
 #include "chrome/test/base/ui_test_utils.h"
+#include "content/public/browser/notification_service.h"
+#include "content/public/browser/render_view_host.h"
 #include "content/public/browser/web_contents.h"
+#include "content/public/browser/web_contents_observer.h"
 #include "content/public/test/browser_test_utils.h"
 #include "content/public/test/test_navigation_observer.h"
 #include "content/test/net/url_request_failed_job.h"
 #include "content/test/net/url_request_mock_http_job.h"
 #include "net/base/net_errors.h"
 #include "net/url_request/url_request_filter.h"
 #include "net/url_request/url_request_job_factory.h"
 
 using content::BrowserThread;
 using content::NavigationController;
@@ skipping 84 matching lines @@
     }
     test_navigation_observer.WaitForObservation(
         base::Bind(&content::RunMessageLoop),
         base::Bind(&MessageLoop::Quit,
                    base::Unretained(MessageLoopForUI::current())));
 
     EXPECT_EQ(title_watcher.WaitAndGetTitle(), ASCIIToUTF16(expected_title));
   }
 };
 
+
+class TestFailProvisionalLoadObserver : public content::WebContentsObserver {
+ public:
+  explicit TestFailProvisionalLoadObserver(content::WebContents* contents)
+      : content::WebContentsObserver(contents) {}
+  virtual ~TestFailProvisionalLoadObserver() {}
+
+  // This method is invoked when the provisional load failed.
+  virtual void DidFailProvisionalLoad(
+      int64 frame_id,
+      bool is_main_frame,
+      const GURL& validated_url,
+      int error_code,
+      const string16& error_description,
+      content::RenderViewHost* render_view_host) OVERRIDE {
+    fail_url_ = validated_url;
+  }
+
+  const GURL& fail_url() const { return fail_url_; }
+
+ private:
+  GURL fail_url_;
+
+  DISALLOW_COPY_AND_ASSIGN(TestFailProvisionalLoadObserver);
+};
+
 // See crbug.com/109669
 #if defined(USE_AURA)
 #define MAYBE_DNSError_Basic DISABLED_DNSError_Basic
 #else
 #define MAYBE_DNSError_Basic DNSError_Basic
 #endif
 // Test that a DNS error occuring in the main frame redirects to an error page.
 IN_PROC_BROWSER_TEST_F(ErrorPageTest, MAYBE_DNSError_Basic) {
   // The first navigation should fail, and the second one should be the error
   // page.
@@ skipping 74 matching lines @@
   GoForwardAndWaitForTitle("Title Of Awesomeness", 1);
 }
 
 // Test that a DNS error occuring in an iframe.
 IN_PROC_BROWSER_TEST_F(ErrorPageTest, IFrameDNSError_Basic) {
   NavigateToURLAndWaitForTitle(
       content::URLRequestMockHTTPJob::GetMockUrl(
           base::FilePath(FILE_PATH_LITERAL("iframe_dns_error.html"))),
       "Blah",
       1);
+  // We expect to have two history entries, since we started off with navigation
+  // to "about:blank" and then navigated to "iframe_dns_error.html".
+  EXPECT_EQ(2,
+      browser()->tab_strip_model()->GetActiveWebContents()->
+          GetController().GetEntryCount());
 }
 
 // This test fails regularly on win_rel trybots. See crbug.com/121540
 #if defined(OS_WIN)
 #define MAYBE_IFrameDNSError_GoBack DISABLED_IFrameDNSError_GoBack
 #else
 #define MAYBE_IFrameDNSError_GoBack IFrameDNSError_GoBack
 #endif
 // Test that a DNS error occuring in an iframe does not result in an
 // additional session history entry.
@@ skipping 11 matching lines @@
 #endif
 // Test that a DNS error occuring in an iframe does not result in an
 // additional session history entry.
 IN_PROC_BROWSER_TEST_F(ErrorPageTest, MAYBE_IFrameDNSError_GoBackAndForward) {
   NavigateToFileURL(FILE_PATH_LITERAL("title2.html"));
   NavigateToFileURL(FILE_PATH_LITERAL("iframe_dns_error.html"));
   GoBackAndWaitForTitle("Title Of Awesomeness", 1);
   GoForwardAndWaitForTitle("Blah", 1);
 }
 
+// Test that a DNS error occuring in an iframe, once the main document is
+// completed loading, does not result in an additional session history entry.
+// To ensure that the main document has completed loading, JavaScript is used to
+// inject an iframe after loading is done.
+IN_PROC_BROWSER_TEST_F(ErrorPageTest, IFrameDNSError_JavaScript) {
+  content::WebContents* wc =
+      browser()->tab_strip_model()->GetActiveWebContents();
+  GURL fail_url =
+      URLRequestFailedJob::GetMockHttpUrl(net::ERR_NAME_NOT_RESOLVED);
+  std::string script = "var frame = document.createElement('iframe');"
+                       "frame.src = '" + fail_url.spec() + "';"
+                       "document.body.appendChild(frame);";
+
+  // Load a regular web page, in which we will inject an iframe.
+  NavigateToFileURL(FILE_PATH_LITERAL("title2.html"));
+
+  // We expect to have two history entries, since we started off with navigation
+  // to "about:blank" and then navigated to "title2.html".
+  EXPECT_EQ(2, wc->GetController().GetEntryCount());
+
+  TestFailProvisionalLoadObserver fail_observer(wc);
+  content::WindowedNotificationObserver load_observer(
+        content::NOTIFICATION_LOAD_STOP,

[Charlie Reis, 2013/05/23 21:53:33]

nit: Wrong indent.

[nasko, 2013/09/20 21:25:39]

Done.

+        content::Source<NavigationController>(&wc->GetController()));
+  wc->GetRenderViewHost()->ExecuteJavascriptInWebFrame(
+      string16(), ASCIIToUTF16(script));
+  load_observer.Wait();

[mmenke, 2013/05/23 21:13:39]

Sorry.  Just skimmed it last time, and didn't notice the two different observer,
which is why I was confused.

[nasko, 2013/09/20 21:25:39]

Done.

+
+  // Ensure we saw the expected failure.
+  EXPECT_EQ(fail_url, fail_observer.fail_url());
+
+  // Failed initial navigation of an iframe shouldn't be adding any history
+  // entries.
+  EXPECT_EQ(2, wc->GetController().GetEntryCount());
+}
+
 // Checks that the Link Doctor is not loaded when we receive an actual 404 page.
 IN_PROC_BROWSER_TEST_F(ErrorPageTest, Page404) {
   NavigateToURLAndWaitForTitle(
       content::URLRequestMockHTTPJob::GetMockUrl(
           base::FilePath(FILE_PATH_LITERAL("page404.html"))),
       "SUCCESS",
       1);
 }
 
 // Protocol handler that fails all requests with net::ERR_ADDRESS_UNREACHABLE.
@@ skipping 72 matching lines @@
   EXPECT_TRUE(content::ExecuteScriptAndExtractBool(
       browser()->tab_strip_model()->GetActiveWebContents(),
       "var textContent = document.body.textContent;"
       "var hasError = textContent.indexOf('ERR_NAME_NOT_RESOLVED') >= 0;"
       "domAutomationController.send(hasError);",
       &result));
   EXPECT_TRUE(result);
 }
 
 }  // namespace