Implement V8ScriptRunner::compileAndRunInternalScript()

Source/bindings/v8/V8ScriptRunner.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
  *    documentation and/or other materials provided with the distribution.
  *
  * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
  * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
  * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
  * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
  * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
  * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
  * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
  * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
  * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
  * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
  * THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
 #include "bindings/v8/V8ScriptRunner.h"
 
+#include "bindings/v8/ScopedPersistent.h"
 #include "bindings/v8/V8Binding.h"
 #include "bindings/v8/V8GCController.h"
 #include "bindings/v8/V8RecursionScope.h"
 #include "core/dom/ScriptExecutionContext.h"
 
 namespace WebCore {
 
 v8::Local<v8::Value> V8ScriptRunner::runCompiledScript(v8::Handle<v8::Script> script, ScriptExecutionContext* context)
 {
     if (script.IsEmpty())
@@ skipping 16 matching lines @@
     if (handleOutOfMemory())
         ASSERT(result.IsEmpty());
 
     if (result.IsEmpty())
         return v8::Local<v8::Value>();
 
     crashIfV8IsDead();
     return result;
 }
 
+v8::Local<v8::Value> V8ScriptRunner::compileAndRunInternalScript(v8::Handle<v8::String> source, v8::Isolate* isolate)
+{
+    v8::HandleScope handleScope;

[abarth-chromium, 2013/05/17 16:21:12]

There's a HandleScope here.

+    ScopedPersistent<v8::Context> context;
+    v8::Local<v8::Value> result;

[abarth-chromium, 2013/05/17 16:21:12]

result is a local handle.

+    context.set(v8::Context::New(isolate));
+    if (context.isEmpty())
+        return result;
+
+    {
+        v8::Context::Scope scope(context.get());
+        v8::TryCatch tryCatch;
+        v8::Handle<v8::Script> script = v8::Script::Compile(source);
+        if (script.IsEmpty() || tryCatch.HasCaught())
+            return result;
+
+        V8RecursionScope::MicrotaskSuppression recursionScope;
+        result = script->Run();
+        if (tryCatch.HasCaught())
+            return result;

[abarth-chromium, 2013/05/17 16:21:12]

... and we return it....  Isn't that a memory corruption pattern?

[haraken, 2013/05/17 16:23:41]

Great catch... I have to use HandleScope::Close().

[haraken, 2013/05/20 00:32:59]

Fixed the stale handlescope issue.

+    }
+
+    context.clear();
+    return result;
+}
+
 } // namespace WebCore