content/browser/loader/resource_dispatcher_host_impl.cc - Issue 1529363006: Introducing SavePackageId and SaveItemId as distinct IdType<...>-based types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/loader/resource_dispatcher_host_impl.cc

Issue 1529363006: Introducing SavePackageId and SaveItemId as distinct IdType<...>-based types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed CR feedback from Daniel. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/loader/resource_dispatcher_host_impl.cc

diff --git a/content/browser/loader/resource_dispatcher_host_impl.cc b/content/browser/loader/resource_dispatcher_host_impl.cc

index 67eaf08af5b96a644010553406426a9dce4e3796..6b122e3655368ee56f281a3f6b2c6fb699f06e97 100644

--- a/content/browser/loader/resource_dispatcher_host_impl.cc

+++ b/content/browser/loader/resource_dispatcher_host_impl.cc

@@ -1779,8 +1779,8 @@ void ResourceDispatcherHostImpl::OnAudioRenderHostStreamStateChanged(

// This function is only used for saving feature.

void ResourceDispatcherHostImpl::BeginSaveFile(const GURL& url,

const Referrer& referrer,

- int save_item_id,

- int save_package_id,

+ SaveItemId save_item_id,

+ SavePackageId save_package_id,

int child_id,

int render_view_route_id,

int render_frame_route_id,

« no previous file with comments | « content/browser/loader/resource_dispatcher_host_impl.h ('k') | content/common/id_type.h » ('j') | no next file with comments »