content/browser/download/save_item.cc - Issue 1529363006: Introducing SavePackageId and SaveItemId as distinct IdType<...>-based types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/download/save_item.cc

Issue 1529363006: Introducing SavePackageId and SaveItemId as distinct IdType<...>-based types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed CR feedback from Daniel. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/download/save_item.cc

diff --git a/content/browser/download/save_item.cc b/content/browser/download/save_item.cc

index 604d659643528166d6c7488391060d3e588b2edd..edea26328044adbc7d319587f0a7956e08b015ab 100644

--- a/content/browser/download/save_item.cc

+++ b/content/browser/download/save_item.cc

@@ -15,10 +15,10 @@ namespace content {

namespace {

-int GetNextSaveItemId() {

- static int g_next_save_item_id = 0;

+SaveItemId GetNextSaveItemId() {

+ static int g_next_save_item_id = 1;

DCHECK_CURRENTLY_ON(BrowserThread::UI);

- return g_next_save_item_id++;

+ return SaveItemId::FromUnsafeValue(g_next_save_item_id++);

}

} // namespace

« no previous file with comments | « content/browser/download/save_item.h ('k') | content/browser/download/save_package.h » ('j') | no next file with comments »